You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Adrian Crum (JIRA)" <ji...@apache.org> on 2007/07/02 22:03:04 UTC
[jira] Created: (OFBIZ-1117) Improved Time Zone Support
Improved Time Zone Support
--------------------------
Key: OFBIZ-1117
URL: https://issues.apache.org/jira/browse/OFBIZ-1117
Project: OFBiz
Issue Type: Improvement
Components: framework
Reporter: Adrian Crum
Priority: Minor
Add user-selected time zone support to the service engine and the screen renderer. Have a TimeZone object available in the service context and the view rendering context.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (OFBIZ-1117) Improved Time Zone Support
Posted by David E Jones <jo...@hotwaxmedia.com>.
I don't know... if I didn't do it this way before it may have been because there was some issue with it. You could try it if you'd like, but we should just keep an eye out for it.
-David
Jacopo Cappellato wrote:
> David,
>
> do you want me to change that code to skip the parameters that are
> internal? I can do it in a minute...
>
> Jacopo
>
>
>
> David E Jones wrote:
>>
>> Thanks for doing that Jacopo. I thought I had implemented the form
>> widget to exclude all service attributes with ModelParam.internal =
>> true, but I guess not! It is an explicit list, though I don't remember
>> why.
>>
>> -David
>>
>>
>> Jacopo Cappellato wrote:
>>> This should be fixed in rev. 553237
>>>
>>> Jacopo
>>>
>>> Rashko Rejmer (JIRA) wrote:
>>>> [
>>>> https://issues.apache.org/jira/browse/OFBIZ-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510210
>>>> ]
>>>> Rashko Rejmer commented on OFBIZ-1117:
>>>> --------------------------------------
>>>>
>>>> Hi all,
>>>> The problem with the error is solved now, but I noticed that all
>>>> form widgets that use "<auto-fields-service" tag have additional
>>>> text field "Time Zone". For example this problem appears in: -
>>>> create new billing account form;
>>>> - Organization Accounting Preferences form;
>>>> - List Agreement Terms form;
>>>> - ...... Regards,
>>>> Rashko Rejmer
>>>>
>>>>> Improved Time Zone Support
>>>>> --------------------------
>>>>>
>>>>> Key: OFBIZ-1117
>>>>> URL: https://issues.apache.org/jira/browse/OFBIZ-1117
>>>>> Project: OFBiz
>>>>> Issue Type: Improvement
>>>>> Components: framework
>>>>> Reporter: Adrian Crum
>>>>> Assignee: Adrian Crum
>>>>> Priority: Minor
>>>>> Fix For: SVN trunk
>>>>>
>>>>> Attachments: time_zone.patch
>>>>>
>>>>>
>>>>> Add user-selected time zone support to the service engine and the
>>>>> screen renderer. Have a TimeZone object available in the service
>>>>> context and the view rendering context.
>>>>
>>>
>
Re: [jira] Commented: (OFBIZ-1117) Improved Time Zone Support
Posted by Jacopo Cappellato <ti...@sastau.it>.
David,
do you want me to change that code to skip the parameters that are
internal? I can do it in a minute...
Jacopo
David E Jones wrote:
>
> Thanks for doing that Jacopo. I thought I had implemented the form
> widget to exclude all service attributes with ModelParam.internal =
> true, but I guess not! It is an explicit list, though I don't remember why.
>
> -David
>
>
> Jacopo Cappellato wrote:
>> This should be fixed in rev. 553237
>>
>> Jacopo
>>
>> Rashko Rejmer (JIRA) wrote:
>>> [
>>> https://issues.apache.org/jira/browse/OFBIZ-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510210
>>> ]
>>> Rashko Rejmer commented on OFBIZ-1117:
>>> --------------------------------------
>>>
>>> Hi all,
>>> The problem with the error is solved now, but I noticed that all form
>>> widgets that use "<auto-fields-service" tag have additional text
>>> field "Time Zone". For example this problem appears in: - create new
>>> billing account form;
>>> - Organization Accounting Preferences form;
>>> - List Agreement Terms form;
>>> - ...... Regards,
>>> Rashko Rejmer
>>>
>>>> Improved Time Zone Support
>>>> --------------------------
>>>>
>>>> Key: OFBIZ-1117
>>>> URL: https://issues.apache.org/jira/browse/OFBIZ-1117
>>>> Project: OFBiz
>>>> Issue Type: Improvement
>>>> Components: framework
>>>> Reporter: Adrian Crum
>>>> Assignee: Adrian Crum
>>>> Priority: Minor
>>>> Fix For: SVN trunk
>>>>
>>>> Attachments: time_zone.patch
>>>>
>>>>
>>>> Add user-selected time zone support to the service engine and the
>>>> screen renderer. Have a TimeZone object available in the service
>>>> context and the view rendering context.
>>>
>>
Re: [jira] Commented: (OFBIZ-1117) Improved Time Zone Support
Posted by David E Jones <jo...@hotwaxmedia.com>.
Thanks for doing that Jacopo. I thought I had implemented the form widget to exclude all service attributes with ModelParam.internal = true, but I guess not! It is an explicit list, though I don't remember why.
-David
Jacopo Cappellato wrote:
> This should be fixed in rev. 553237
>
> Jacopo
>
> Rashko Rejmer (JIRA) wrote:
>> [
>> https://issues.apache.org/jira/browse/OFBIZ-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510210
>> ]
>> Rashko Rejmer commented on OFBIZ-1117:
>> --------------------------------------
>>
>> Hi all,
>> The problem with the error is solved now, but I noticed that all form
>> widgets that use "<auto-fields-service" tag have additional text field
>> "Time Zone". For example this problem appears in: - create new
>> billing account form;
>> - Organization Accounting Preferences form;
>> - List Agreement Terms form;
>> - ......
>> Regards,
>> Rashko Rejmer
>>
>>> Improved Time Zone Support
>>> --------------------------
>>>
>>> Key: OFBIZ-1117
>>> URL: https://issues.apache.org/jira/browse/OFBIZ-1117
>>> Project: OFBiz
>>> Issue Type: Improvement
>>> Components: framework
>>> Reporter: Adrian Crum
>>> Assignee: Adrian Crum
>>> Priority: Minor
>>> Fix For: SVN trunk
>>>
>>> Attachments: time_zone.patch
>>>
>>>
>>> Add user-selected time zone support to the service engine and the
>>> screen renderer. Have a TimeZone object available in the service
>>> context and the view rendering context.
>>
>
Re: [jira] Commented: (OFBIZ-1117) Improved Time Zone Support
Posted by Jacopo Cappellato <ti...@sastau.it>.
This should be fixed in rev. 553237
Jacopo
Rashko Rejmer (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/OFBIZ-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510210 ]
>
> Rashko Rejmer commented on OFBIZ-1117:
> --------------------------------------
>
> Hi all,
>
> The problem with the error is solved now, but I noticed that all form widgets that use "<auto-fields-service" tag have additional text field "Time Zone".
> For example this problem appears in:
> - create new billing account form;
> - Organization Accounting Preferences form;
> - List Agreement Terms form;
> - ......
>
> Regards,
> Rashko Rejmer
>
>> Improved Time Zone Support
>> --------------------------
>>
>> Key: OFBIZ-1117
>> URL: https://issues.apache.org/jira/browse/OFBIZ-1117
>> Project: OFBiz
>> Issue Type: Improvement
>> Components: framework
>> Reporter: Adrian Crum
>> Assignee: Adrian Crum
>> Priority: Minor
>> Fix For: SVN trunk
>>
>> Attachments: time_zone.patch
>>
>>
>> Add user-selected time zone support to the service engine and the screen renderer. Have a TimeZone object available in the service context and the view rendering context.
>
[jira] Commented: (OFBIZ-1117) Improved Time Zone Support
Posted by "Rashko Rejmer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510210 ]
Rashko Rejmer commented on OFBIZ-1117:
--------------------------------------
Hi all,
The problem with the error is solved now, but I noticed that all form widgets that use "<auto-fields-service" tag have additional text field "Time Zone".
For example this problem appears in:
- create new billing account form;
- Organization Accounting Preferences form;
- List Agreement Terms form;
- ......
Regards,
Rashko Rejmer
> Improved Time Zone Support
> --------------------------
>
> Key: OFBIZ-1117
> URL: https://issues.apache.org/jira/browse/OFBIZ-1117
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: time_zone.patch
>
>
> Add user-selected time zone support to the service engine and the screen renderer. Have a TimeZone object available in the service context and the view rendering context.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1117) Improved Time Zone Support
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516159 ]
Jacques Le Roux commented on OFBIZ-1117:
----------------------------------------
Rashko,
I don't know if it has been fixed since, but I can't see any additional text field "Time Zone" in create new billing account form nor in Organization Accounting Preferences form.
> Improved Time Zone Support
> --------------------------
>
> Key: OFBIZ-1117
> URL: https://issues.apache.org/jira/browse/OFBIZ-1117
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: time_zone.patch
>
>
> Add user-selected time zone support to the service engine and the screen renderer. Have a TimeZone object available in the service context and the view rendering context.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1117) Improved Time Zone Support
Posted by "Rashko Rejmer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510146 ]
Rashko Rejmer commented on OFBIZ-1117:
--------------------------------------
Hi David, Adrian,
I tried to create order and I got this error:
"The Following Errors Occurred:
Unknown parameter found: [sendOrderConfirmation.timeZone]"
Maybe this is a separate issue, but I think that this is connected with those new implovements.
Regards,
Rashko Rejmer
> Improved Time Zone Support
> --------------------------
>
> Key: OFBIZ-1117
> URL: https://issues.apache.org/jira/browse/OFBIZ-1117
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: time_zone.patch
>
>
> Add user-selected time zone support to the service engine and the screen renderer. Have a TimeZone object available in the service context and the view rendering context.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1117) Improved Time Zone Support
Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510150 ]
David E. Jones commented on OFBIZ-1117:
---------------------------------------
I should have tested this more before committing... I guess I wrongly assumed that had been done.
This problem should be fixed in rev 553183. The "timeZone" attribute is now on all services automatically.
> Improved Time Zone Support
> --------------------------
>
> Key: OFBIZ-1117
> URL: https://issues.apache.org/jira/browse/OFBIZ-1117
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: time_zone.patch
>
>
> Add user-selected time zone support to the service engine and the screen renderer. Have a TimeZone object available in the service context and the view rendering context.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1117) Improved Time Zone Support
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1117:
-------------------------------
Attachment: time_zone.patch
The advantage to this improvement can be seen in line 71 of header.ftl in the attached patch. Displaying/printing a properly formatted date/time in the user's locale and time zone takes only one line of code.
> Improved Time Zone Support
> --------------------------
>
> Key: OFBIZ-1117
> URL: https://issues.apache.org/jira/browse/OFBIZ-1117
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: time_zone.patch
>
>
> Add user-selected time zone support to the service engine and the screen renderer. Have a TimeZone object available in the service context and the view rendering context.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1117) Improved Time Zone Support
Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David E. Jones closed OFBIZ-1117.
---------------------------------
Resolution: Fixed
Fix Version/s: SVN trunk
Assignee: Adrian Crum
This looks like a nice enhancement Adrian. While I don't think this is complete it's fine for now and support for this in service and other infrastructure will undoubtedly flesh out over time (just like "locale" is supported, for example).
It's in SVN rev 553122.
> Improved Time Zone Support
> --------------------------
>
> Key: OFBIZ-1117
> URL: https://issues.apache.org/jira/browse/OFBIZ-1117
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: time_zone.patch
>
>
> Add user-selected time zone support to the service engine and the screen renderer. Have a TimeZone object available in the service context and the view rendering context.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1117) Improved Time Zone Support
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510201 ]
Adrian Crum commented on OFBIZ-1117:
------------------------------------
David,
Thank you for the commit and for catching the error. I had done some limited testing, but I guess it wasn't enough.
> Improved Time Zone Support
> --------------------------
>
> Key: OFBIZ-1117
> URL: https://issues.apache.org/jira/browse/OFBIZ-1117
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: time_zone.patch
>
>
> Add user-selected time zone support to the service engine and the screen renderer. Have a TimeZone object available in the service context and the view rendering context.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1117) Improved Time Zone Support
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510148 ]
Ashish Vijaywargiya commented on OFBIZ-1117:
--------------------------------------------
Hi,
I am also getting the same error in the anonymous checkout process.
--
Ashish Vijaywargiya
> Improved Time Zone Support
> --------------------------
>
> Key: OFBIZ-1117
> URL: https://issues.apache.org/jira/browse/OFBIZ-1117
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: time_zone.patch
>
>
> Add user-selected time zone support to the service engine and the screen renderer. Have a TimeZone object available in the service context and the view rendering context.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.