You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/06/10 11:04:30 UTC

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4138: Fixed incorrect error message on invalid template type download

DaanHoogland commented on a change in pull request #4138:
URL: https://github.com/apache/cloudstack/pull/4138#discussion_r438040173



##########
File path: core/src/main/java/com/cloud/storage/template/HttpTemplateDownloader.java
##########
@@ -218,7 +218,10 @@ public long download(boolean resume, DownloadCompleteCallback callback) {
             errorString = hte.getMessage();
         } catch (IOException ioe) {
             status = TemplateDownloader.Status.UNRECOVERABLE_ERROR; //probably a file write error?
-            errorString = ioe.getMessage();
+            // Let's not overwrite the original error message.
+            if (errorString.isEmpty()){

Review comment:
       errorString contains a single space initially. String.isEmpty returns (this.value.length == 0)
   so this is never happening.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org