[GitHub] [ratis] szetszwo commented on a diff in pull request #638: Add follower information for leader to know follower when follower is slow

[GitBox <gi...@apache.org>]

szetszwo commented on code in PR #638:
URL: https://github.com/apache/ratis/pull/638#discussion_r861553997


##########
ratis-server-api/src/main/java/org/apache/ratis/statemachine/StateMachine.java:
##########
@@ -204,10 +205,11 @@ interface LeaderEventApi {
      * This notification is based on "raft.server.rpc.slowness.timeout".
      *
      * @param roleInfoProto information about the current node role and rpc delay information
+     * @param followerInfo information about slow follower
      *
      * @see org.apache.ratis.server.RaftServerConfigKeys.Rpc#SLOWNESS_TIMEOUT_KEY
      */
-    default void notifyFollowerSlowness(RoleInfoProto roleInfoProto) {}
+    default void notifyFollowerSlowness(RoleInfoProto roleInfoProto, FollowerInfo followerInfo) {}

Review Comment:
   @inomp3042 , thanks for working on this.  Since FollowerInfo is in the Leader package, it should not appear in the StateMachine API.  How about marking the follower as slow in RoleInfoProto?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org