You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Jacek Laskowski <ja...@laskowski.net.pl> on 2008/08/02 11:16:30 UTC

Re: svn commit: r681934 - in /geronimo/devtools/eclipse-plugin/trunk/testsuite/plugins: org.apache.geronimo.testsuite.common/src/main/java/org/apache/geronimo/testsuite/common/ui/ org.apache.geronimo.testsuite.v20/src/main/java/org/apache/geronimo/te

On Sat, Aug 2, 2008 at 5:32 AM,  <mc...@apache.org> wrote:
> Author: mcconne
> Date: Fri Aug  1 20:32:20 2008
> New Revision: 681934
>
> URL: http://svn.apache.org/viewvc?rev=681934&view=rev
> Log:
> GERONIMODEVTOOLS-444 Patch to open web browser inside Eclipse. Thanks to BJ Reed for this patch !!
>
> Modified:
>    geronimo/devtools/eclipse-plugin/trunk/testsuite/plugins/org.apache.geronimo.testsuite.common/src/main/java/org/apache/geronimo/testsuite/common/ui/AbbotHelper.java
>    geronimo/devtools/eclipse-plugin/trunk/testsuite/plugins/org.apache.geronimo.testsuite.common/src/main/java/org/apache/geronimo/testsuite/common/ui/ServerTasks.java
>    geronimo/devtools/eclipse-plugin/trunk/testsuite/plugins/org.apache.geronimo.testsuite.common/src/main/java/org/apache/geronimo/testsuite/common/ui/Tutorial5Minute.java
>    geronimo/devtools/eclipse-plugin/trunk/testsuite/plugins/org.apache.geronimo.testsuite.v20/src/main/java/org/apache/geronimo/testsuite/v20/ui/Tutorial5MinuteTest.java
>    geronimo/devtools/eclipse-plugin/trunk/testsuite/plugins/org.apache.geronimo.testsuite.v21/src/main/java/org/apache/geronimo/testsuite/v21/ui/Tutorial5MinuteTest.java

Well, the patch was needed, but it's nearly impossible to find out
what had changed. I think the formatting was broken. I think the
change should be reverted and commited again.

Jacek

-- 
Jacek Laskowski
Notatnik Projektanta Java EE - http://www.JacekLaskowski.pl

Re: svn commit: r681934 - in /geronimo/devtools/eclipse-plugin/trunk/testsuite/plugins: org.apache.geronimo.testsuite.common/src/main/java/org/apache/geronimo/testsuite/common/ui/ org.apache.geronimo.testsuite.v20/src/main/java/org/apache/geronimo/te

Posted by Tim McConnell <ti...@gmail.com>.
Thanks Jacek, I'll do as you suggest......

Jacek Laskowski wrote:
> On Sat, Aug 2, 2008 at 5:32 AM,  <mc...@apache.org> wrote:
>> Author: mcconne
>> Date: Fri Aug  1 20:32:20 2008
>> New Revision: 681934
>>
>> URL: http://svn.apache.org/viewvc?rev=681934&view=rev
>> Log:
>> GERONIMODEVTOOLS-444 Patch to open web browser inside Eclipse. Thanks to BJ Reed for this patch !!
>>
>> Modified:
>>    geronimo/devtools/eclipse-plugin/trunk/testsuite/plugins/org.apache.geronimo.testsuite.common/src/main/java/org/apache/geronimo/testsuite/common/ui/AbbotHelper.java
>>    geronimo/devtools/eclipse-plugin/trunk/testsuite/plugins/org.apache.geronimo.testsuite.common/src/main/java/org/apache/geronimo/testsuite/common/ui/ServerTasks.java
>>    geronimo/devtools/eclipse-plugin/trunk/testsuite/plugins/org.apache.geronimo.testsuite.common/src/main/java/org/apache/geronimo/testsuite/common/ui/Tutorial5Minute.java
>>    geronimo/devtools/eclipse-plugin/trunk/testsuite/plugins/org.apache.geronimo.testsuite.v20/src/main/java/org/apache/geronimo/testsuite/v20/ui/Tutorial5MinuteTest.java
>>    geronimo/devtools/eclipse-plugin/trunk/testsuite/plugins/org.apache.geronimo.testsuite.v21/src/main/java/org/apache/geronimo/testsuite/v21/ui/Tutorial5MinuteTest.java
> 
> Well, the patch was needed, but it's nearly impossible to find out
> what had changed. I think the formatting was broken. I think the
> change should be reverted and commited again.
> 
> Jacek
> 

-- 
Thanks,
Tim McConnell