You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by zhangh43 <gi...@git.apache.org> on 2017/02/23 05:14:27 UTC
[GitHub] incubator-hawq pull request #1140: HAWQ-1358. Refactor gpfdist library in fe...
GitHub user zhangh43 opened a pull request:
https://github.com/apache/incubator-hawq/pull/1140
HAWQ-1358. Refactor gpfdist library in featuretest.
extract gpfdist code(which exists in exttable test case) as a common library, to be used by both exttable and ranger feature test.
Main functions:
gpfdist_init: to setup gpfdist environment and start server.
gpfdist_finalize: to stop gpfdist server.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangh43/incubator-hawq hawq1358
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1140.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1140
----
commit a84c0f9d1ab049cb16133f64935e96b9df1b9d8f
Author: chunlingwang and hubertzhang <pa...@apache.org>
Date: 2017-02-23T05:05:48Z
HAWQ-1358. Refactor gpfdist library in featuretest.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1140: HAWQ-1358. Refactor gpfdist library in fe...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1140#discussion_r102643869
--- Diff: src/test/feature/lib/gpfdist.cpp ---
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include <fstream>
+#include "gpfdist.h"
+
+using std::string;
+
+namespace hawq {
+namespace test {
+void GPfdist::init_gpfdist() {
+ auto sql =
+ "CREATE EXTERNAL WEB TABLE gpfdist_status (x text) "
+ "execute E'( python %s/bin/lib/gppinggpfdist.py localhost:7070 2>&1 || echo) ' "
+ "on SEGMENT 0 "
+ "FORMAT 'text' (delimiter '|');";
+ auto GPHOME = getenv("GPHOME");
+ util->execute(hawq::test::stringFormat(sql, GPHOME));
+
+ sql =
+ "CREATE EXTERNAL WEB TABLE gpfdist_start (x text) "
+ "execute E'((%s/bin/gpfdist -p 7070 -d %s </dev/null >/dev/null 2>&1 &); sleep 2; echo \"starting\"...) ' "
+ "on SEGMENT 0 "
+ "FORMAT 'text' (delimiter '|');";
+ std::string path = util->getTestRootPath() + "/ExternalSource/data";
+ util->execute(hawq::test::stringFormat(sql, GPHOME, path.c_str()));
+
+ util->execute(
+ "CREATE EXTERNAL WEB TABLE gpfdist_stop (x text) "
+ "execute E'(/bin/pkill gpfdist || killall gpfdist) > /dev/null 2>&1; echo stopping...' "
--- End diff --
Do not hardcode path for those utilities. e.g. On my linux box pkill is under /usr/bin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1140: HAWQ-1358. Refactor gpfdist library in fe...
Posted by zhangh43 <gi...@git.apache.org>.
Github user zhangh43 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1140
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1140: HAWQ-1358. Refactor gpfdist library in fe...
Posted by zhangh43 <gi...@git.apache.org>.
Github user zhangh43 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1140#discussion_r102663969
--- Diff: src/test/feature/lib/gpfdist.cpp ---
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include <fstream>
+#include "gpfdist.h"
+
+using std::string;
+
+namespace hawq {
+namespace test {
+void GPfdist::init_gpfdist() {
+ auto sql =
+ "CREATE EXTERNAL WEB TABLE gpfdist_status (x text) "
+ "execute E'( python %s/bin/lib/gppinggpfdist.py localhost:7070 2>&1 || echo) ' "
+ "on SEGMENT 0 "
+ "FORMAT 'text' (delimiter '|');";
+ auto GPHOME = getenv("GPHOME");
+ util->execute(hawq::test::stringFormat(sql, GPHOME));
+
+ sql =
+ "CREATE EXTERNAL WEB TABLE gpfdist_start (x text) "
+ "execute E'((%s/bin/gpfdist -p 7070 -d %s </dev/null >/dev/null 2>&1 &); sleep 2; echo \"starting\"...) ' "
+ "on SEGMENT 0 "
+ "FORMAT 'text' (delimiter '|');";
+ std::string path = util->getTestRootPath() + "/ExternalSource/data";
+ util->execute(hawq::test::stringFormat(sql, GPHOME, path.c_str()));
+
+ util->execute(
+ "CREATE EXTERNAL WEB TABLE gpfdist_stop (x text) "
+ "execute E'(/bin/pkill gpfdist || killall gpfdist) > /dev/null 2>&1; echo stopping...' "
--- End diff --
remove the hardcode path. using pkill instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1140: HAWQ-1358. Refactor gpfdist library in featurete...
Posted by linwen <gi...@git.apache.org>.
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1140
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---