You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/11/02 16:28:00 UTC

[jira] [Commented] (AIRFLOW-3959) Representation of Dags in WEB UI - Folder View

    [ https://issues.apache.org/jira/browse/AIRFLOW-3959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16965415#comment-16965415 ] 

ASF GitHub Bot commented on AIRFLOW-3959:
-----------------------------------------

zacharya19 commented on pull request #6489: [AIRFLOW-3959] add UI filter with DAGs tags
URL: https://github.com/apache/airflow/pull/6489
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW-3959) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   In order to allow multiple teams and users to use the same Airflow instance, I've added a tagging option for DAGs.
   Each dag can have one, a few or none tags, then the user can filter in the homepage specific tags.
   The filtering is saved in a cookie to save the user preferences.
   ![image](https://user-images.githubusercontent.com/5796188/68073910-b9c68a00-fd9d-11e9-8c0d-42336af8d073.png)
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   test_home_filter_tags in view tests, to check if the cookie is set properly.
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Representation of Dags in WEB UI - Folder View
> ----------------------------------------------
>
>                 Key: AIRFLOW-3959
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3959
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: ui
>    Affects Versions: 1.10.2
>            Reporter: Yuva
>            Priority: Major
>
> Is there any option/plan to have Folder level categorisation of DAGS in WebUI. Suppose we have directories a & b under /dags and each have ten dags. Web UI should display all the directories within /dags and clicking on each directory should display dags inside it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)