[jira] [Commented] (FLINK-8317) Enable Triggering of Savepoints via RestfulGateway

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307518#comment-16307518 ] 

ASF GitHub Bot commented on FLINK-8317:
---------------------------------------

GitHub user GJL opened a pull request:

    https://github.com/apache/flink/pull/5223

    [FLINK-8317][flip6] Implement Triggering of Savepoints

    ## What is the purpose of the change
    
    *Implement triggering of savepoints through HTTP and through command line in FLIP-6 mode. This PR is based on #5207.*
    
    CC: @tillrohrmann 
    
    ## Brief change log
    
    - *Allow triggering of savepoints through RestfulGateway.*
    - *Implement REST handlers to trigger and query the status of savepoints.*
    - *Implement savepoint command in RestClusterClient.*
    
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
      - *Added unit tests for REST handlesr, and `RestClusterClient`*
      - *Manually deployed the `SocketWindowWordCount` job and triggered a savepoint using Flink's command line client and `curl`*
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/GJL/flink FLINK-8317-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5223.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5223
    
----
commit e91f15fcbbe52d6d47cc1ba3d35ae4768fc6309d
Author: gyao <ga...@...>
Date:   2017-12-19T17:58:53Z

    [FLINK-8234][flip6] Cache JobExecutionResult in Dispatcher
    
    - Introduce new JobExecutionResult used by JobMaster to forward the information in
      the already existing JobExecutionResult.
    - Always cache a JobExecutionResult. Even in case of job failures. In case of
      job failures, the serialized exception is stored additionally.
    - Introduce new methods to RestfulGateway to allow retrieval of cached
      JobExecutionResults

commit 748745ac3521a20040cbda4056dfd9c53bc24a82
Author: gyao <ga...@...>
Date:   2017-12-20T13:44:03Z

    [FLINK-8233][flip6] Add JobExecutionResultHandler
    
        - Allow retrieval of the JobExecutionResult cached in Dispatcher.
        - Implement serializer and deserializer for JobExecutionResult.

commit adf091a2770f42d6f8a0c19ab88cc7a208943a32
Author: gyao <ga...@...>
Date:   2017-12-20T13:44:26Z

    [hotfix] Clean up ExecutionGraph
    
    - Remove unnecessary throws clause.
    - Format whitespace.

commit f5c28527b3a1a0c8ec52f2a5616ebb634397b69c
Author: gyao <ga...@...>
Date:   2017-12-22T23:02:10Z

    [FLINK-8299][flip6] Retrieve JobExecutionResult after job submission

commit 55d920f628d7ef3f5b0db7fd843dfdd2d96a3917
Author: gyao <ga...@...>
Date:   2018-01-01T17:59:42Z

    [FLINK-8317][flip6] Implement savepoints in RestClusterClient
    
    Allow triggering of savepoints through RestfulGateway. Implement REST handlers
    to trigger and query the status of savepoints. Implement
    savepoint command in RestClusterClient.

----


> Enable Triggering of Savepoints via RestfulGateway
> --------------------------------------------------
>
>                 Key: FLINK-8317
>                 URL: https://issues.apache.org/jira/browse/FLINK-8317
>             Project: Flink
>          Issue Type: New Feature
>          Components: Distributed Coordination, REST
>    Affects Versions: 1.5.0
>            Reporter: Gary Yao
>            Assignee: Gary Yao
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> Enable triggering of savepoints in FLIP-6 mode via RestfulGateway:
> * Add method to {{CompletableFuture<CompletedCheckpoint> triggerSavepoint(long timestamp, String targetDirectory)}} to interface
> * Implement method in {{Dispatcher}} and {{JobMaster}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)