[jira] [Commented] (TS-2744) TSNetAcceptNamedProtocol asserts for unknown protocols

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13988174#comment-13988174 ] 

ASF subversion and git services commented on TS-2744:
-----------------------------------------------------

Commit ea7849384139a0ae8308fe12dc0741c4390953e1 in trafficserver's branch refs/heads/master from [~jpeach@apache.org]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=ea78493 ]

TS-2744: remove TSNetAcceptNamedProtocol assertion for unknown protocols

TSNetAcceptNamedProtocol is supposed to accept arbitrary strings
because it lets you implement your own protocol plugin over TLS,
using NPN or ALPN to demux the session. TS-2431 added an assertion
to SSLNextProtocolSet::NextProtocolEndpoint::NextProtocolEndpoint
when an unknown protocol is registered. There's no "unknown" value
in TSProtoType, but it is safe to mark unrecognized protocols as
TS_PROTO_TLS.


> TSNetAcceptNamedProtocol asserts for unknown protocols
> ------------------------------------------------------
>
>                 Key: TS-2744
>                 URL: https://issues.apache.org/jira/browse/TS-2744
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: TS API
>            Reporter: James Peach
>            Assignee: James Peach
>             Fix For: 5.0.0
>
>
> {{TSNetAcceptNamedProtocol}} is supposed to accept arbitrary strings because it lets you implement your own protocol plugin over TLS, using NPN or ALPN to demux the session. TS-2431 broke this by adding an assertion to {{SSLNextProtocolSet::NextProtocolEndpoint::NextProtocolEndpoint}} when an unknown protocol is registered. A large part of the point of this API is to allow you to register your own protocol.



--
This message was sent by Atlassian JIRA
(v6.2#6252)