[incubator-pinot] branch master updated: Added a log message on pinot-server when controller leadership change is read from zookeeper. (#3522)

[mc...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

mcvsubbu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new fdb9357  Added a log message on pinot-server when controller leadership change is read from zookeeper. (#3522)
fdb9357 is described below

commit fdb9357353ac601906bda716fda3902e2256fd7d
Author: Subbu Subramaniam <mc...@users.noreply.github.com>
AuthorDate: Tue Nov 20 08:46:53 2018 -0800

    Added a log message on pinot-server when controller leadership change is read from zookeeper. (#3522)
    
    Recently we saw a case where the server was repeatedly reporting that it received NOT_LEADER
    responses from the controller. On further look at the logs, it turned out that the controller
    did not get a helix notification that it became leader, so the server was logging what it saw
    in zookeeper.
    
    The behavior did lead us into looking at other things before we found the root cause.
    
    This log will clearly identify how the server concludes who it thinks the leader is.
---
 .../com/linkedin/pinot/server/realtime/ControllerLeaderLocator.java     | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/pinot-core/src/main/java/com/linkedin/pinot/server/realtime/ControllerLeaderLocator.java b/pinot-core/src/main/java/com/linkedin/pinot/server/realtime/ControllerLeaderLocator.java
index 4c2c915..f6ee054 100644
--- a/pinot-core/src/main/java/com/linkedin/pinot/server/realtime/ControllerLeaderLocator.java
+++ b/pinot-core/src/main/java/com/linkedin/pinot/server/realtime/ControllerLeaderLocator.java
@@ -94,6 +94,8 @@ public class ControllerLeaderLocator {
       int leaderPort = Integer.valueOf(leader.substring(index + 1));
       _controllerLeaderHostPort = new Pair<>(leaderHost, leaderPort);
       _cachedControllerLeaderInvalid = false;
+      LOGGER.info("Setting controller leader to be {}:{} as per znode version {}, mtime {}", leaderHost, leaderPort,
+          stat.getVersion(), stat.getMtime());
       return _controllerLeaderHostPort;
     } catch (Exception e) {
       LOGGER.warn("Could not locate controller leader, exception", e);


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org