[GitHub] [incubator-dolphinscheduler] Rubik-W commented on a change in pull request #2943: Sqoop task optimization

[GitBox <gi...@apache.org>]

Rubik-W commented on a change in pull request #2943:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2943#discussion_r438067714



##########
File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sqoop/generator/SqoopJobGenerator.java
##########
@@ -62,14 +63,23 @@ private void createSqoopJobGenerator(String sourceType,String targetType){
      * @return
      */
     public String generateSqoopJob(SqoopParameters sqoopParameters,TaskExecutionContext taskExecutionContext){
-        createSqoopJobGenerator(sqoopParameters.getSourceType(),sqoopParameters.getTargetType());
-        if(sourceGenerator == null || targetGenerator == null){
-            return null;
+
+        String sqoopScripts = "";
+
+        if (SqoopJobType.TEMPLATE.getDescp().equals(sqoopParameters.getJobType())) {
+            createSqoopJobGenerator(sqoopParameters.getSourceType(),sqoopParameters.getTargetType());
+            if(sourceGenerator == null || targetGenerator == null){
+                return null;
+            }

Review comment:
       If return null, I see the follow-up code, the task will eventually be judged as successful.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org