You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "chiacyu (via GitHub)" <gi...@apache.org> on 2024/10/12 13:09:05 UTC
[PR] KAFKA-17773: Upgrade spotbug to work under java 23 [kafka]
chiacyu opened a new pull request, #17483:
URL: https://github.com/apache/kafka/pull/17483
As titled, please check [KAFKA-17773](https://issues.apache.org/jira/browse/KAFKA-17773) for more details, thanks!
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17773: Upgrade spotbug to work under java 23 [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #17483:
URL: https://github.com/apache/kafka/pull/17483#issuecomment-2408620823
@chiacyu Could you please upgrade spotbug gradle plugin?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17773: Upgrade spotbug to work under java 23 [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #17483:
URL: https://github.com/apache/kafka/pull/17483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17773: Upgrade spotbug to work under java 23 [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #17483:
URL: https://github.com/apache/kafka/pull/17483#discussion_r1798464920
##########
build.gradle:
##########
@@ -42,7 +42,7 @@ plugins {
// When updating the spotbugs gradle plugin, check if it already
// includes spotbugs version 4.7.4, in which case CVE-2022-42920 can
Review Comment:
Could you please cleanup the comment and remove related suppressions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17773: Upgrade spotbug to work under java 23 [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #17483:
URL: https://github.com/apache/kafka/pull/17483#discussion_r1800487655
##########
build.gradle:
##########
@@ -39,10 +39,7 @@ plugins {
id 'org.nosphere.apache.rat' version "0.8.1"
id "io.swagger.core.v3.swagger-gradle-plugin" version "${swaggerVersion}"
- // When updating the spotbugs gradle plugin, check if it already
- // includes spotbugs version 4.7.4, in which case CVE-2022-42920 can
- // be dropped from gradle/resources/dependencycheck-suppressions.xml
- id "com.github.spotbugs" version '5.1.3' apply false
+ id "com.github.spotbugs" version '6.0.24' apply false
Review Comment:
Could you please use the latest version `6.0.25`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org