You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/31 05:16:08 UTC

[GitHub] [flink] xintongsong opened a new pull request #10728: [FLINK-15437][yarn] Apply dynamic properties early on client side.

xintongsong opened a new pull request #10728: [FLINK-15437][yarn] Apply dynamic properties early on client side.
URL: https://github.com/apache/flink/pull/10728
 
 
   ## What is the purpose of the change
   
   This PR applies dynamic properties early on client side, to make sure the client uses the correct configurations set via dynamic properties.
   
   ## Brief change log
   
   - 475b6421a1d94a5073e177d217311d9f195307cd: Write yarn properties file without `YarnClusterDescriptor`.
   - 322a65907fc3ee936a1ceca930e5427b235e6dc4: Apply dynamic properties early on client side.
   
   ## Verifying this change
   
   - Updated `FlinkYarnSessionCliTest#testDynamicProperties`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] TisonKun closed pull request #10728: [FLINK-15437][yarn] Apply dynamic properties early on client side.

Posted by GitBox <gi...@apache.org>.
TisonKun closed pull request #10728: [FLINK-15437][yarn] Apply dynamic properties early on client side.
URL: https://github.com/apache/flink/pull/10728
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10728: [FLINK-15437][yarn] Apply dynamic properties early on client side.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10728: [FLINK-15437][yarn] Apply dynamic properties early on client side.
URL: https://github.com/apache/flink/pull/10728#issuecomment-569870948
 
 
   <!--
   Meta data
   Hash:4bae53183e1268380abdb6d6ad1f9c8b48b32d83 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142720750 TriggerType:PUSH TriggerID:4bae53183e1268380abdb6d6ad1f9c8b48b32d83
   Hash:4bae53183e1268380abdb6d6ad1f9c8b48b32d83 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4002 TriggerType:PUSH TriggerID:4bae53183e1268380abdb6d6ad1f9c8b48b32d83
   Hash:4cd98f18541f0610d7b9ccd30138e23e8a001a21 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4046 TriggerType:PUSH TriggerID:4cd98f18541f0610d7b9ccd30138e23e8a001a21
   Hash:4cd98f18541f0610d7b9ccd30138e23e8a001a21 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142865002 TriggerType:PUSH TriggerID:4cd98f18541f0610d7b9ccd30138e23e8a001a21
   -->
   ## CI report:
   
   * 4bae53183e1268380abdb6d6ad1f9c8b48b32d83 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142720750) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4002) 
   * 4cd98f18541f0610d7b9ccd30138e23e8a001a21 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142865002) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4046) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10728: [FLINK-15437][yarn] Apply dynamic properties early on client side.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10728: [FLINK-15437][yarn] Apply dynamic properties early on client side.
URL: https://github.com/apache/flink/pull/10728#issuecomment-569865897
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 322a65907fc3ee936a1ceca930e5427b235e6dc4 (Tue Dec 31 05:18:13 UTC 2019)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10728: [FLINK-15437][yarn] Apply dynamic properties early on client side.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10728: [FLINK-15437][yarn] Apply dynamic properties early on client side.
URL: https://github.com/apache/flink/pull/10728#issuecomment-569870948
 
 
   <!--
   Meta data
   Hash:4bae53183e1268380abdb6d6ad1f9c8b48b32d83 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142720750 TriggerType:PUSH TriggerID:4bae53183e1268380abdb6d6ad1f9c8b48b32d83
   Hash:4bae53183e1268380abdb6d6ad1f9c8b48b32d83 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4002 TriggerType:PUSH TriggerID:4bae53183e1268380abdb6d6ad1f9c8b48b32d83
   Hash:4cd98f18541f0610d7b9ccd30138e23e8a001a21 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4046 TriggerType:PUSH TriggerID:4cd98f18541f0610d7b9ccd30138e23e8a001a21
   Hash:4cd98f18541f0610d7b9ccd30138e23e8a001a21 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142865002 TriggerType:PUSH TriggerID:4cd98f18541f0610d7b9ccd30138e23e8a001a21
   -->
   ## CI report:
   
   * 4bae53183e1268380abdb6d6ad1f9c8b48b32d83 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142720750) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4002) 
   * 4cd98f18541f0610d7b9ccd30138e23e8a001a21 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142865002) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4046) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10728: [FLINK-15437][yarn] Apply dynamic properties early on client side.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10728: [FLINK-15437][yarn] Apply dynamic properties early on client side.
URL: https://github.com/apache/flink/pull/10728#issuecomment-569870948
 
 
   <!--
   Meta data
   Hash:4bae53183e1268380abdb6d6ad1f9c8b48b32d83 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142720750 TriggerType:PUSH TriggerID:4bae53183e1268380abdb6d6ad1f9c8b48b32d83
   Hash:4bae53183e1268380abdb6d6ad1f9c8b48b32d83 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4002 TriggerType:PUSH TriggerID:4bae53183e1268380abdb6d6ad1f9c8b48b32d83
   Hash:4cd98f18541f0610d7b9ccd30138e23e8a001a21 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:4cd98f18541f0610d7b9ccd30138e23e8a001a21
   -->
   ## CI report:
   
   * 4bae53183e1268380abdb6d6ad1f9c8b48b32d83 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142720750) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4002) 
   * 4cd98f18541f0610d7b9ccd30138e23e8a001a21 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10728: [FLINK-15437][yarn] Apply dynamic properties early on client side.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10728: [FLINK-15437][yarn] Apply dynamic properties early on client side.
URL: https://github.com/apache/flink/pull/10728#issuecomment-569870948
 
 
   <!--
   Meta data
   Hash:4bae53183e1268380abdb6d6ad1f9c8b48b32d83 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:4bae53183e1268380abdb6d6ad1f9c8b48b32d83
   -->
   ## CI report:
   
   * 4bae53183e1268380abdb6d6ad1f9c8b48b32d83 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10728: [FLINK-15437][yarn] Apply dynamic properties early on client side.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10728: [FLINK-15437][yarn] Apply dynamic properties early on client side.
URL: https://github.com/apache/flink/pull/10728#issuecomment-569870948
 
 
   <!--
   Meta data
   Hash:4bae53183e1268380abdb6d6ad1f9c8b48b32d83 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142720750 TriggerType:PUSH TriggerID:4bae53183e1268380abdb6d6ad1f9c8b48b32d83
   Hash:4bae53183e1268380abdb6d6ad1f9c8b48b32d83 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4002 TriggerType:PUSH TriggerID:4bae53183e1268380abdb6d6ad1f9c8b48b32d83
   Hash:4cd98f18541f0610d7b9ccd30138e23e8a001a21 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4046 TriggerType:PUSH TriggerID:4cd98f18541f0610d7b9ccd30138e23e8a001a21
   Hash:4cd98f18541f0610d7b9ccd30138e23e8a001a21 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142865002 TriggerType:PUSH TriggerID:4cd98f18541f0610d7b9ccd30138e23e8a001a21
   -->
   ## CI report:
   
   * 4bae53183e1268380abdb6d6ad1f9c8b48b32d83 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142720750) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4002) 
   * 4cd98f18541f0610d7b9ccd30138e23e8a001a21 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142865002) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4046) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] xintongsong commented on issue #10728: [FLINK-15437][yarn] Apply dynamic properties early on client side.

Posted by GitBox <gi...@apache.org>.
xintongsong commented on issue #10728: [FLINK-15437][yarn] Apply dynamic properties early on client side.
URL: https://github.com/apache/flink/pull/10728#issuecomment-570444840
 
 
   Thanks for the review, @TisonKun.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10728: [FLINK-15437][yarn] Apply dynamic properties early on client side.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10728: [FLINK-15437][yarn] Apply dynamic properties early on client side.
URL: https://github.com/apache/flink/pull/10728#issuecomment-569870948
 
 
   <!--
   Meta data
   Hash:4bae53183e1268380abdb6d6ad1f9c8b48b32d83 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142720750 TriggerType:PUSH TriggerID:4bae53183e1268380abdb6d6ad1f9c8b48b32d83
   Hash:4bae53183e1268380abdb6d6ad1f9c8b48b32d83 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4002 TriggerType:PUSH TriggerID:4bae53183e1268380abdb6d6ad1f9c8b48b32d83
   -->
   ## CI report:
   
   * 4bae53183e1268380abdb6d6ad1f9c8b48b32d83 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142720750) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4002) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wangyang0918 commented on a change in pull request #10728: [FLINK-15437][yarn] Apply dynamic properties early on client side.

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #10728: [FLINK-15437][yarn] Apply dynamic properties early on client side.
URL: https://github.com/apache/flink/pull/10728#discussion_r362416234
 
 

 ##########
 File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
 ##########
 @@ -1045,10 +1031,6 @@ private ApplicationReport startAppMaster(
 			appMasterEnv.put(YarnConfigKeys.ENV_KRB5_PATH, remoteKrb5Path.toString());
 		}
 
-		if (dynamicPropertiesEncoded != null) {
 
 Review comment:
   Since we have apply all the dynamic properties to the client uploaded flink configuration, so we will not need to set the `ENV_DYNAMIC_PROPERTIES` and parse it in the jobmanager. So `YarnConfigKeys.ENV_DYNAMIC_PROPERTIES` could be removed and all the usage on the jobmanager side should also be removed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] xintongsong commented on issue #10728: [FLINK-15437][yarn] Apply dynamic properties early on client side.

Posted by GitBox <gi...@apache.org>.
xintongsong commented on issue #10728: [FLINK-15437][yarn] Apply dynamic properties early on client side.
URL: https://github.com/apache/flink/pull/10728#issuecomment-570182541
 
 
   @wangyang0918 Thanks for the review, comments addressed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10728: [FLINK-15437][yarn] Apply dynamic properties early on client side.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10728: [FLINK-15437][yarn] Apply dynamic properties early on client side.
URL: https://github.com/apache/flink/pull/10728#issuecomment-569870948
 
 
   <!--
   Meta data
   Hash:4bae53183e1268380abdb6d6ad1f9c8b48b32d83 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142720750 TriggerType:PUSH TriggerID:4bae53183e1268380abdb6d6ad1f9c8b48b32d83
   Hash:4bae53183e1268380abdb6d6ad1f9c8b48b32d83 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4002 TriggerType:PUSH TriggerID:4bae53183e1268380abdb6d6ad1f9c8b48b32d83
   -->
   ## CI report:
   
   * 4bae53183e1268380abdb6d6ad1f9c8b48b32d83 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142720750) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4002) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] xintongsong commented on issue #10728: [FLINK-15437][yarn] Apply dynamic properties early on client side.

Posted by GitBox <gi...@apache.org>.
xintongsong commented on issue #10728: [FLINK-15437][yarn] Apply dynamic properties early on client side.
URL: https://github.com/apache/flink/pull/10728#issuecomment-569865874
 
 
   cc @wangyang0918 @TisonKun @kl0u 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wangyang0918 commented on a change in pull request #10728: [FLINK-15437][yarn] Apply dynamic properties early on client side.

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #10728: [FLINK-15437][yarn] Apply dynamic properties early on client side.
URL: https://github.com/apache/flink/pull/10728#discussion_r362418438
 
 

 ##########
 File path: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java
 ##########
 @@ -369,6 +372,14 @@ public Configuration applyCommandLineOptionsToConfiguration(CommandLine commandL
 			effectiveConfiguration.setInteger(TaskManagerOptions.NUM_TASK_SLOTS, Integer.parseInt(commandLine.getOptionValue(slots.getOpt())));
 		}
 
+		dynamicPropertiesEncoded = encodeDynamicProperties(commandLine);
+		if (dynamicPropertiesEncoded != null && !dynamicPropertiesEncoded.isEmpty()) {
 
 Review comment:
   I think the null check is unnecessary since the `encodeDynamicProperties` will always return a `NonNull` value.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services