You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tez.apache.org by GitBox <gi...@apache.org> on 2019/05/10 09:10:02 UTC

[GitHub] [tez] jteagles commented on a change in pull request #42: TEZ-4068: Prevent new speculative attempt after task has issued canCo…

jteagles commented on a change in pull request #42: TEZ-4068: Prevent new speculative attempt after task has issued canCo…
URL: https://github.com/apache/tez/pull/42#discussion_r282805520
 
 

 ##########
 File path: tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/TaskImpl.java
 ##########
 @@ -1027,7 +1027,7 @@ public void transition(TaskImpl task, TaskEvent event) {
       TaskAttempt earliestUnfinishedAttempt = null;
       for (TaskAttempt ta : task.attempts.values()) {
         // find the oldest running attempt
-        if (!ta.isFinished()) {
+        if (!ta.isFinished() && task.commitAttempt == null) {
 
 Review comment:
   Thanks for this patch @Chyler. This has the correct behavior, but the LOG.info below may give the wrong reason. Can this be improved to log the two cases separately?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services