[Impala-ASF-CR] IMPALA-110 (part 1): Refactor ExecNode::buffer pool client

["Thomas Marshall (Code Review)" <ge...@cloudera.org>]

Hello Tim Armstrong, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10493

to look at the new patch set (#2).

Change subject: IMPALA-110 (part 1): Refactor ExecNode::buffer_pool_client_
......................................................................

IMPALA-110 (part 1): Refactor ExecNode::buffer_pool_client_

IMPALA-110 will involve refactoring PartitionedAggregationNode by
separating out the aggregation logic into a new type called
Aggregator, and then supporting multiple Aggregators per node to allow
for multiple aggregation classes to be evaluated at the same time.

Each Aggregator will need to have its own memory reservation to
operate, and we can do this by giving each Aggregator its own
BufferPool::ClientHandle instead of using the usual
ExecNode::buffer_pool_client_.

To facilitate this, this patch refactors all of the
buffer_pool_client_ related logic into a new class,
ReservationManager, so that eventually each Aggregator can have its
own ReservationManager and the logic in ClaimBufferReservation(),
ReleaseUnusedReservation(), etc. won't be duplicated.

Change-Id: I75f92c3f4f05adeef11a70f59e0c8ff2d19bc17a
---
M be/src/exec/analytic-eval-node.cc
M be/src/exec/exec-node.cc
M be/src/exec/exec-node.h
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/hdfs-scan-node-mt.cc
M be/src/exec/hdfs-scan-node.cc
M be/src/exec/partial-sort-node.cc
M be/src/exec/partitioned-aggregation-node.cc
M be/src/exec/partitioned-hash-join-node.cc
M be/src/exec/sort-node.cc
M be/src/runtime/CMakeLists.txt
A be/src/runtime/reservation-manager.cc
A be/src/runtime/reservation-manager.h
13 files changed, 284 insertions(+), 164 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/10493/2
-- 
To view, visit http://gerrit.cloudera.org:8080/10493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I75f92c3f4f05adeef11a70f59e0c8ff2d19bc17a
Gerrit-Change-Number: 10493
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>