[GitHub] [incubator-doris] morningman commented on a change in pull request #7020: [Colocate] Fix bug that colocate group can not be redistributed after dropping a backend

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #7020:
URL: https://github.com/apache/incubator-doris/pull/7020#discussion_r745349807



##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/ColocateTableIndex.java
##########
@@ -206,13 +207,14 @@ public void addBackendsPerBucketSeqByTag(GroupId groupId, Tag tag, List<List<Lon
         }
     }
 
-    public void markGroupUnstable(GroupId groupId, boolean needEditLog) {
+    public void markGroupUnstable(GroupId groupId, String reason, boolean needEditLog) {

Review comment:
       Error code is not necessary. Because currently this reason is only for human reading.
   I tried to use string constants. But reason like:
   `get unhealthy tablet %d in colocate table. status: %s`
   is dynamic changed.
   So not all reasons can be constants




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org