[GitHub] [incubator-tvm] mbrookhart commented on a change in pull request #5983: Dynamic Tile Op

[GitBox <gi...@apache.org>]

mbrookhart commented on a change in pull request #5983:
URL: https://github.com/apache/incubator-tvm/pull/5983#discussion_r450353012



##########
File path: src/relay/transforms/dynamic_to_static.cc
##########
@@ -46,6 +47,14 @@ class DynamicToStaticMutator : public MixedModeMutator {
         static const Op& reshape = Op::Get("reshape");
         return Call(reshape, {call_node->args[0]}, Attrs(attrs), {});
       }
+    } else if (call_node->op == dyn_tile_op_) {

Review comment:
       I think we'll need to, there's no other way to dispatch on individual ops types. We could do it with a switch statement for performance, or implement a registry lookup to move the code out of of this function.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org