You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/16 07:33:51 UTC
[GitHub] [cloudstack-primate] davidjumani opened a new pull request #809: Hiding boot mode and boot type for VMware
davidjumani opened a new pull request #809:
URL: https://github.com/apache/cloudstack-primate/pull/809
VMware doesn't respect boot mode and type for templates, so hiding them
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #809: Hiding boot mode and boot type for VMware
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #809:
URL: https://github.com/apache/cloudstack-primate/pull/809#issuecomment-709911205
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] nvazquez commented on pull request #809: Hiding boot mode and boot type for VMware
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #809:
URL: https://github.com/apache/cloudstack-primate/pull/809#issuecomment-712323474
Ok, now we are selectively hiding the boot type if the template is a deploy-as-is (newly registered on VMware)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #809: Hiding boot mode and boot type for VMware
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #809:
URL: https://github.com/apache/cloudstack-primate/pull/809#issuecomment-712776257
@davidjumani was a backend fix added to https://github.com/apache/cloudstack/pull/4307 ? which commit/reference is that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] nvazquez commented on pull request #809: Hiding boot mode and boot type for VMware
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #809:
URL: https://github.com/apache/cloudstack-primate/pull/809#issuecomment-711486964
I have fixed the templates registration along with API changes on PR4307, will no longer send a guest OS ID for Vmware templates registration, but reverted the boot type hiding
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb commented on pull request #809: Hiding boot mode and boot type for VMware
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #809:
URL: https://github.com/apache/cloudstack-primate/pull/809#issuecomment-712649038
only 7 minutes to build packages vs 30_ minutes previously...nice.... 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb commented on pull request #809: Hiding boot mode and boot type for VMware
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #809:
URL: https://github.com/apache/cloudstack-primate/pull/809#issuecomment-713365661
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #809: Hiding boot mode and boot type for VMware
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #809:
URL: https://github.com/apache/cloudstack-primate/pull/809#issuecomment-712646220
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/809 (JID-3602)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb merged pull request #809: Hiding boot mode and boot type for VMware
Posted by GitBox <gi...@apache.org>.
andrijapanicsb merged pull request #809:
URL: https://github.com/apache/cloudstack-primate/pull/809
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #809: Hiding boot mode and boot type for VMware
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #809:
URL: https://github.com/apache/cloudstack-primate/pull/809#issuecomment-709916165
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/809 (JID-3594)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #809: Hiding boot mode and boot type for VMware
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #809:
URL: https://github.com/apache/cloudstack-primate/pull/809#issuecomment-712757623
@andrijapanicsb @nvazquez @harikrishna-patnala - should we merge this? backend changes are in https://github.com/apache/cloudstack/pull/4307?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #809: Hiding boot mode and boot type for VMware
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #809:
URL: https://github.com/apache/cloudstack-primate/pull/809#issuecomment-713424350
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/809 (JID-3608)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #809: Hiding boot mode and boot type for VMware
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #809:
URL: https://github.com/apache/cloudstack-primate/pull/809#issuecomment-713366095
@andrijapanicsb a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] nvazquez commented on pull request #809: Hiding boot mode and boot type for VMware
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #809:
URL: https://github.com/apache/cloudstack-primate/pull/809#issuecomment-710047611
@andrijapanicsb @DaanHoogland @davidjumani we should only hide if its Vmware and deploy-as-is, for the older templates that should be still visible
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on pull request #809: Hiding boot mode and boot type for VMware
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #809:
URL: https://github.com/apache/cloudstack-primate/pull/809#issuecomment-709896894
ok, in view of `deploy-as-is` this makes sense, but I think it should blocked/handled in the API as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #809: Hiding boot mode and boot type for VMware
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #809:
URL: https://github.com/apache/cloudstack-primate/pull/809#issuecomment-711882037
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/809 (JID-3599)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] nvazquez commented on pull request #809: Hiding boot mode and boot type for VMware
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #809:
URL: https://github.com/apache/cloudstack-primate/pull/809#issuecomment-713175418
Latest addition pushed - @andrijapanicsb to confirm if its good to go in
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb commented on pull request #809: Hiding boot mode and boot type for VMware
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #809:
URL: https://github.com/apache/cloudstack-primate/pull/809#issuecomment-710169692
Agree @nvazquez - my bad for not giving this input to @davidjumani , thx for pointing out
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb commented on pull request #809: Hiding boot mode and boot type for VMware
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #809:
URL: https://github.com/apache/cloudstack-primate/pull/809#issuecomment-711871958
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #809: Hiding boot mode and boot type for VMware
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #809:
URL: https://github.com/apache/cloudstack-primate/pull/809#issuecomment-711873164
@andrijapanicsb a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb commented on pull request #809: Hiding boot mode and boot type for VMware
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #809:
URL: https://github.com/apache/cloudstack-primate/pull/809#issuecomment-713710528
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #809: Hiding boot mode and boot type for VMware
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #809:
URL: https://github.com/apache/cloudstack-primate/pull/809#issuecomment-712641760
@andrijapanicsb a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb commented on pull request #809: Hiding boot mode and boot type for VMware
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #809:
URL: https://github.com/apache/cloudstack-primate/pull/809#issuecomment-712641522
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #809: Hiding boot mode and boot type for VMware
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #809:
URL: https://github.com/apache/cloudstack-primate/pull/809#issuecomment-709911781
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb commented on pull request #809: Hiding boot mode and boot type for VMware
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #809:
URL: https://github.com/apache/cloudstack-primate/pull/809#issuecomment-712796614
@nvazquez added the commit to PR 4307, so yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org