You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Ryan Morlok (JIRA)" <ji...@apache.org> on 2016/11/22 19:41:58 UTC

[jira] [Created] (AIRFLOW-645) HttpHook ignores https

Ryan Morlok created AIRFLOW-645:
-----------------------------------

             Summary: HttpHook ignores https
                 Key: AIRFLOW-645
                 URL: https://issues.apache.org/jira/browse/AIRFLOW-645
             Project: Apache Airflow
          Issue Type: Bug
          Components: hooks
    Affects Versions: Airflow 2.0, Airflow 1.7.1
            Reporter: Ryan Morlok


When loading an https connection from an environment variable, HttpHook leverages BaseHook's get_connection(...) method which will load the string from the environment variable. It will then parse the URI.

HttpHook will then use the base_url as the connection's host, which always strips off the protocol. It does a useless check to see if the bsae_url starts with http, and since it doesn't it always appends http://, losing the https.

I think 

self.base_url = conn.host

in http_hook.py should be updated to:

self.base_url = conn.conn_type + conn.host



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)