You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@xalan.apache.org by tm...@apache.org on 2001/09/06 17:10:19 UTC
cvs commit: xml-xalan/java/src/org/apache/xalan/xsltc/compiler XslAttribute.java
tmiller 01/09/06 08:10:19
Modified: java/src/org/apache/xalan/xsltc/compiler XslAttribute.java
Log:
bug fix 3320, gunnlaugur briem's fix
Revision Changes Path
1.10 +3 -2 xml-xalan/java/src/org/apache/xalan/xsltc/compiler/XslAttribute.java
Index: XslAttribute.java
===================================================================
RCS file: /home/cvs/xml-xalan/java/src/org/apache/xalan/xsltc/compiler/XslAttribute.java,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- XslAttribute.java 2001/08/08 10:57:05 1.9
+++ XslAttribute.java 2001/09/06 15:10:19 1.10
@@ -1,5 +1,5 @@
/*
- * @(#)$Id: XslAttribute.java,v 1.9 2001/08/08 10:57:05 morten Exp $
+ * @(#)$Id: XslAttribute.java,v 1.10 2001/09/06 15:10:19 tmiller Exp $
*
* The Apache Software License, Version 1.1
*
@@ -60,7 +60,7 @@
* @author Santiago Pericas-Geertsen
* @author Morten Jorgensen
* @author Erwin Bolwidt <ej...@klomp.org>
- *
+ * @author Gunnlaugur Briem <gt...@dimon.is>
*/
package org.apache.xalan.xsltc.compiler;
@@ -130,6 +130,7 @@
// The output handler will generate an error if not (at runtime)
if (item instanceof If) continue;
if (item instanceof Choose) continue;
+ if (item instanceof CopyOf) continue; // bug fix 3320, g. briem
_ignore = true;
reportWarning(this, parser, ErrorMsg.ATTROUTS_ERR, name);
return;
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-cvs-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-cvs-help@xml.apache.org
RE: cvs commit: xml-xalan/java/src/org/apache/xalan/xsltc/compiler XslAttribute.java
Posted by Gunnlaugur Thor Briem <gt...@dimon.is>.
Hi Todd,
I suspect that this fix is insufficient. It corrects
the error in the case of an xsl:copy-of preceding the
xsl:attribute, but I suspect the error will still be
raised if the xsl:attribute is preceded by, for
instance, an xsl:call-template to a template that
only adds an attribute. More cases may exist, and I'm
not familiar enough with the design to anticipate them
at first glance, so you or Morten should probably
figure out all the cases. All this code is allowed to
do is eliminate any case where a non-attribute node is
*definitely* going to be added to the result tree before
the xsl:attribute. In any "maybe" cases, this code must
not do _ignore = true (instead the determination must
be left to runtime operation).
Right?
- Gulli
> -----Original Message-----
> From: tmiller@apache.org [mailto:tmiller@apache.org]
> Sent: 6. september 2001 15:10
> To: xml-xalan-cvs@apache.org
> Subject: cvs commit: xml-xalan/java/src/org/apache/xalan/xsltc/compiler
> XslAttribute.java
>
>
> tmiller 01/09/06 08:10:19
>
> Modified: java/src/org/apache/xalan/xsltc/compiler XslAttribute.java
> Log:
> bug fix 3320, gunnlaugur briem's fix
>
> Revision Changes Path
> 1.10 +3 -2 xml-xalan/java/src/org/apache/xalan/xsltc/compiler/XslAttribute.java
>
> Index: XslAttribute.java
> ===================================================================
> RCS file: /home/cvs/xml-xalan/java/src/org/apache/xalan/xsltc/compiler/XslAttribute.java,v
> retrieving revision 1.9
> retrieving revision 1.10
> diff -u -r1.9 -r1.10
> --- XslAttribute.java 2001/08/08 10:57:05 1.9
> +++ XslAttribute.java 2001/09/06 15:10:19 1.10
> @@ -1,5 +1,5 @@
> /*
> - * @(#)$Id: XslAttribute.java,v 1.9 2001/08/08 10:57:05 morten Exp $
> + * @(#)$Id: XslAttribute.java,v 1.10 2001/09/06 15:10:19 tmiller Exp $
> *
> * The Apache Software License, Version 1.1
> *
> @@ -60,7 +60,7 @@
> * @author Santiago Pericas-Geertsen
> * @author Morten Jorgensen
> * @author Erwin Bolwidt <ej...@klomp.org>
> - *
> + * @author Gunnlaugur Briem <gt...@dimon.is>
> */
>
> package org.apache.xalan.xsltc.compiler;
> @@ -130,6 +130,7 @@
> // The output handler will generate an error if not (at runtime)
> if (item instanceof If) continue;
> if (item instanceof Choose) continue;
> + if (item instanceof CopyOf) continue; // bug fix 3320, g. briem
> _ignore = true;
> reportWarning(this, parser, ErrorMsg.ATTROUTS_ERR, name);
> return;
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: xalan-cvs-unsubscribe@xml.apache.org
> For additional commands, e-mail: xalan-cvs-help@xml.apache.org
>