You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/09/15 14:43:21 UTC

[kudu-CR] [transactions] Adjust Java package for transactions.proto

Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16451


Change subject: [transactions] Adjust Java package for transactions.proto
......................................................................

[transactions] Adjust Java package for transactions.proto

This patch moves the Java package for transactions.proto
from `kudu.transactions` to `org.apache.kudu.transactions`
to match the location of the other generated Java classes.

Change-Id: I69866e0688a9ef9378b7615ecbb5c3089c3d85fd
---
M src/kudu/transactions/transactions.proto
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/16451/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16451
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I69866e0688a9ef9378b7615ecbb5c3089c3d85fd
Gerrit-Change-Number: 16451
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>

[kudu-CR] [transactions] Adjust Java package for transactions.proto

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16451 )

Change subject: [transactions] Adjust Java package for transactions.proto
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16451
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69866e0688a9ef9378b7615ecbb5c3089c3d85fd
Gerrit-Change-Number: 16451
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Sep 2020 17:27:32 +0000
Gerrit-HasComments: No

[kudu-CR] [transactions] Adjust Java package for transactions.proto

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16451 )

Change subject: [transactions] Adjust Java package for transactions.proto
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16451
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69866e0688a9ef9378b7615ecbb5c3089c3d85fd
Gerrit-Change-Number: 16451
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Sep 2020 16:47:02 +0000
Gerrit-HasComments: No

[kudu-CR] [transactions] Adjust Java package for transactions.proto

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16451 )

Change subject: [transactions] Adjust Java package for transactions.proto
......................................................................

[transactions] Adjust Java package for transactions.proto

This patch moves the Java package for transactions.proto
from `kudu.transactions` to `org.apache.kudu.transactions`
to match the location of the other generated Java classes.

Change-Id: I69866e0688a9ef9378b7615ecbb5c3089c3d85fd
Reviewed-on: http://gerrit.cloudera.org:8080/16451
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/transactions/transactions.proto
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved
  Andrew Wong: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/16451
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I69866e0688a9ef9378b7615ecbb5c3089c3d85fd
Gerrit-Change-Number: 16451
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)