[Impala-ASF-CR] IMPALA-5394: Handle blocked HS2 connections

["Henry Robinson (Code Review)" <ge...@cloudera.org>]

Henry Robinson has posted comments on this change.

Change subject: IMPALA-5394: Handle blocked HS2 connections
......................................................................


Patch Set 4:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/7061/4/be/src/rpc/TAcceptQueueServer.cpp
File be/src/rpc/TAcceptQueueServer.cpp:

PS4, Line 167: maxTasks_
nit: be explicit with maxTasks_ > 0


PS4, Line 211: // Use multiple threads to ensure that other connections can proceed if SetupConnection
             :   // blocks for a prior connection
comment should probably be reverted as well


http://gerrit.cloudera.org:8080/#/c/7061/4/be/src/rpc/thrift-server.h
File be/src/rpc/thrift-server.h:

PS4, Line 104: num_worker_threads: the number of worker threads to use in any thread pool
update comment to say what 0 means


http://gerrit.cloudera.org:8080/#/c/7061/4/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

PS4, Line 1963: exec_env->metrics(), FLAGS_fe_service_threads, ThriftServer::ThreadPool);
Let's make this change for beeswax as well.


PS4, Line 1985: Threaded
Maybe we can just remove Threaded and ThreadPool and just pass in the number of worker threads?


http://gerrit.cloudera.org:8080/#/c/7061/4/be/src/transport/TSaslServerTransport.cpp
File be/src/transport/TSaslServerTransport.cpp:

PS4, Line 158: VLOG_EVERY_N(2, 100) << "getTransport(): transportMap_ size is: "
             :                          << transportMap_.size();
seems chatty, any reason to keep it?


-- 
To view, visit http://gerrit.cloudera.org:8080/7061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56a5f3d9cf931cff14eae7f236fea018236a6255
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Sherman <jf...@arcadiadata.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@arcadiadata.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: Yes