You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Ram Mettu (Code Review)" <ge...@cloudera.org> on 2016/08/14 05:20:32 UTC
[kudu-CR] KUDU-1522 Fix AlterTable Timestamp col with default value
Ram Mettu has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3970
Change subject: KUDU-1522 Fix AlterTable Timestamp col with default value
......................................................................
KUDU-1522 Fix AlterTable Timestamp col with default value
Change-Id: Id5a9ef473af3f205b33e6ef6061a29a362435a4c
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M src/kudu/common/types.h
2 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/3970/1
--
To view, visit http://gerrit.cloudera.org:8080/3970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id5a9ef473af3f205b33e6ef6061a29a362435a4c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
[kudu-CR] KUDU-1522 Fix AlterTable Timestamp col with default value
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has abandoned this change.
Change subject: KUDU-1522 Fix AlterTable Timestamp col with default value
......................................................................
Abandoned
Yea, looks like the new commit had a different 'Change-Id' line than the original. That causes it to be created as a new review instead of a new revision of this one. No big deal, closing this one out.
Thanks for finding and fixing the bug!
--
To view, visit http://gerrit.cloudera.org:8080/3970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: Id5a9ef473af3f205b33e6ef6061a29a362435a4c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-1522 Fix AlterTable Timestamp col with default value
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1522 Fix AlterTable Timestamp col with default value
......................................................................
Patch Set 1:
(2 comments)
Thanks for fixing this. Just a small style nit.
http://gerrit.cloudera.org:8080/#/c/3970/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java:
Line 75: // Try adding three columns, where one has default value, nullable and Timestamp with default value
nit: would you mind wrapping this line to 100 columns or less?
Line 79: .addColumn("testaddmulticolTimestampcol", Type.TIMESTAMP, (System.currentTimeMillis() * 1000));
same as above
--
To view, visit http://gerrit.cloudera.org:8080/3970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5a9ef473af3f205b33e6ef6061a29a362435a4c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1522 Fix AlterTable Timestamp col with default value
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: KUDU-1522 Fix AlterTable Timestamp col with default value
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2867/
--
To view, visit http://gerrit.cloudera.org:8080/3970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5a9ef473af3f205b33e6ef6061a29a362435a4c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] KUDU-1522 Fix AlterTable Timestamp col with default value
Posted by "Ram Mettu (Code Review)" <ge...@cloudera.org>.
Ram Mettu has posted comments on this change.
Change subject: KUDU-1522 Fix AlterTable Timestamp col with default value
......................................................................
Patch Set 1:
@Todd I fixed your comments, it created a new gerrit code review - may be something wrong on my part. https://gerrit.cloudera.org/#/c/3980/1
--
To view, visit http://gerrit.cloudera.org:8080/3970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5a9ef473af3f205b33e6ef6061a29a362435a4c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No