[GitHub] [hive] pvary commented on a change in pull request #2316: HIVE-25161: Implement partitioned CTAS for iceberg tables

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #2316:
URL: https://github.com/apache/hive/pull/2316#discussion_r639480737



##########
File path: iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergSerDe.java
##########
@@ -218,7 +235,15 @@ private static Schema hiveSchemaOrThrow(Properties serDeProperties, Exception pr
       throws SerDeException {
     // Read the configuration parameters
     String columnNames = serDeProperties.getProperty(serdeConstants.LIST_COLUMNS);
+    // add partition columns to schema as well, if any
+    if (serDeProperties.getProperty(serdeConstants.LIST_PARTITION_COLUMNS) != null) {
+      columnNames = columnNames + "," + serDeProperties.getProperty(serdeConstants.LIST_PARTITION_COLUMNS);
+    }

Review comment:
       nit: newline




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org