You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by bbende <gi...@git.apache.org> on 2017/01/06 20:14:56 UTC
[GitHub] nifi pull request #1404: NIFI-3299 Adding example of sensitive property key ...
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/1404
NIFI-3299 Adding example of sensitive property key migration to the a\u2026
\u2026dmin guide
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bbende/nifi 3299
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1404.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1404
----
commit 11c71dd9de4321f2203b8f8d2f8d67d8ca893247
Author: Bryan Bende <bb...@apache.org>
Date: 2017-01-06T20:12:57Z
NIFI-3299 Adding example of sensitive property key migration to the admin guide
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1404: NIFI-3299 Adding example of sensitive property key ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1404
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1404: NIFI-3299 Adding example of sensitive property key migrati...
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/1404
@bbende This looks good, thanks for the submission. I added a couple formatting elements and a little further description of the `-x` flag (see my separate additions [here](https://github.com/alopresto/nifi/commit/61987ded4b54032967376b900ce39333987a209c)).
Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1404: NIFI-3299 Adding example of sensitive property key migrati...
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/1404
Added [sub-section headers](https://github.com/alopresto/nifi/commit/e3f08a512ec8143d319ed55097b81ed08cde0bc8) as per @andrewmlim .
Merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1404: NIFI-3299 Adding example of sensitive property key migrati...
Posted by andrewmlim <gi...@git.apache.org>.
Github user andrewmlim commented on the issue:
https://github.com/apache/nifi/pull/1404
This is a good addition to the doc for this tool.
Now that we have two separate use cases, I suggest adding two new sub-sections within the "Encrypt-Config Tool" section. Something like this:
**Key Migration**
In order to change the key used to encrypt the sensitive values, indicate migration mode using the -m or --migrate flag...
.
.
.
old password \u2192 new key
old password \u2192 new password
**Existing Flow Migration**
This tool can also be used to change the value of nifi.sensitive.props.key for an existing flow...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1404: NIFI-3299 Adding example of sensitive property key migrati...
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/1404
@andrewmlim just saw your comment and I agree. I will add those sub-section headers before merging (and update my NIFI-3299 branch for posterity).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---