[GitHub] [incubator-pinot] daniellavoie commented on pull request #6440: Add authentication for write endpoints of Controller resources

[GitBox <gi...@apache.org>]

daniellavoie commented on pull request #6440:
URL: https://github.com/apache/incubator-pinot/pull/6440#issuecomment-759884459


   Great feature addition! This is long time due for Pinot. Thanks for investing your time on this area.
   
   Out of curiosity, have you considered implementing authorization declaratively at a servlet filter level rather than on each individual endpoints? Authorization and authentication being an orthogonal concern, I feel it would be less intrusive in the code base if basic CRUD rules could be defined across all endpoints rather than requiring a specific implementation on every endpoint.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org