You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by David Mackey <td...@booleanhaiku.com> on 2013/02/06 05:39:20 UTC
Review Request: Update multihashmap to compile with GCC 4.7
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9323/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Description
-------
As of 4.7, GCC longer performs many extra unqualified lookups.
Fully qualify dependent functions to resolve 4.7 build failure.
This addresses bug MESOS-271.
https://issues.apache.org/jira/browse/MESOS-271
Diffs
-----
third_party/libprocess/include/stout/multihashmap.hpp 6d324d4
Diff: https://reviews.apache.org/r/9323/diff/
Testing
-------
make check passes.
Thanks,
David Mackey
Re: Review Request: Update multihashmap to compile with GCC 4.7
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9323/#review16208
-----------------------------------------------------------
third_party/libprocess/include/stout/multihashmap.hpp
<https://reviews.apache.org/r/9323/#comment34643>
Line wrap at 80 columns (comments at 70).
third_party/libprocess/include/stout/multihashmap.hpp
<https://reviews.apache.org/r/9323/#comment34644>
Ditto.
- Benjamin Hindman
On Feb. 6, 2013, 4:39 a.m., David Mackey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9323/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2013, 4:39 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> As of 4.7, GCC longer performs many extra unqualified lookups.
> Fully qualify dependent functions to resolve 4.7 build failure.
>
>
> This addresses bug MESOS-271.
> https://issues.apache.org/jira/browse/MESOS-271
>
>
> Diffs
> -----
>
> third_party/libprocess/include/stout/multihashmap.hpp 6d324d4
>
> Diff: https://reviews.apache.org/r/9323/diff/
>
>
> Testing
> -------
>
> make check passes.
>
>
> Thanks,
>
> David Mackey
>
>
Re: Review Request: Update multihashmap to compile with GCC 4.7
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9323/#review16232
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Feb. 6, 2013, 11:34 p.m., David Mackey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9323/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2013, 11:34 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> As of 4.7, GCC longer performs many extra unqualified lookups.
> Fully qualify dependent functions to resolve 4.7 build failure.
>
>
> This addresses bug MESOS-271.
> https://issues.apache.org/jira/browse/MESOS-271
>
>
> Diffs
> -----
>
> third_party/libprocess/include/stout/multihashmap.hpp 6d324d4
>
> Diff: https://reviews.apache.org/r/9323/diff/
>
>
> Testing
> -------
>
> make check passes.
>
>
> Thanks,
>
> David Mackey
>
>
Re: Review Request: Update multihashmap to compile with GCC 4.7
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9323/#review17050
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 6, 2013, 11:34 p.m., David Mackey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9323/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2013, 11:34 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> As of 4.7, GCC longer performs many extra unqualified lookups.
> Fully qualify dependent functions to resolve 4.7 build failure.
>
>
> This addresses bug MESOS-271.
> https://issues.apache.org/jira/browse/MESOS-271
>
>
> Diffs
> -----
>
> third_party/libprocess/include/stout/multihashmap.hpp 6d324d4
>
> Diff: https://reviews.apache.org/r/9323/diff/
>
>
> Testing
> -------
>
> make check passes.
>
>
> Thanks,
>
> David Mackey
>
>
Re: Review Request: Update multihashmap to compile with GCC 4.7
Posted by David Mackey <td...@booleanhaiku.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9323/
-----------------------------------------------------------
(Updated Feb. 6, 2013, 11:34 p.m.)
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Changes
-------
Update patch with proper code style.
Description
-------
As of 4.7, GCC longer performs many extra unqualified lookups.
Fully qualify dependent functions to resolve 4.7 build failure.
This addresses bug MESOS-271.
https://issues.apache.org/jira/browse/MESOS-271
Diffs (updated)
-----
third_party/libprocess/include/stout/multihashmap.hpp 6d324d4
Diff: https://reviews.apache.org/r/9323/diff/
Testing
-------
make check passes.
Thanks,
David Mackey