You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/08/16 06:35:25 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request, #6643: [WIP] vmware: fix vm snapshot with datastore cluster, drs
shwstppr opened a new pull request, #6643:
URL: https://github.com/apache/cloudstack/pull/6643
### Description
Fixes #6595
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1227224938
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1223609730
@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1222122413
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1227357073
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1223490360
<b>Trillian test result (tid-4751)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42466 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6643-t4751-vmware-65u2.zip
Smoke tests completed. 100 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_change_service_offering_for_vm_with_snapshots | `Error` | 131.34 | test_vm_snapshots.py
test_01_create_vm_snapshots | `Error` | 126.77 | test_vm_snapshots.py
test_02_revert_vm_snapshots | `Failure` | 90.26 | test_vm_snapshots.py
test_03_delete_vm_snapshots | `Error` | 2.10 | test_vm_snapshots.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1223644031
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1222244988
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1223468348
<b>Trillian test result (tid-4749)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40154 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6643-t4749-xenserver-71.zip
Smoke tests completed. 101 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1225590168
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6643 (SL-JID-2215)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1222255924
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6643 (SL-JID-2200)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1222515801
@shwstppr a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1224651277
<b>Trillian test result (tid-4754)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42097 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6643-t4754-vmware-65u2.zip
Smoke tests completed. 101 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1225644586
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1225582958
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1225688762
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1223462606
<b>Trillian test result (tid-4750)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39578 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6643-t4750-kvm-centos7.zip
Smoke tests completed. 100 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 624.87 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1225584318
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1223608819
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1223608427
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1227307076
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6643)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6643&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6643&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6643&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6643&metric=new_coverage&view=list) [8.2% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6643&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6643&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6643&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1227223785
@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1227647960
@blueorangutan test centos7 vmware-70u2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1227226117
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1225644483
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr merged pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
shwstppr merged PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1222302736
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4039
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1223613988
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6643 (SL-JID-2208)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1222121441
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1222132113
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6643 (SL-JID-2196)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1227648752
@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + vmware-70u2) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a diff in pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
shwstppr commented on code in PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#discussion_r953667300
##########
engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/vmsnapshot/DefaultVMSnapshotStrategy.java:
##########
@@ -325,12 +329,24 @@ protected void finalizeRevert(VMSnapshotVO vmSnapshot, List<VolumeObjectTO> volu
private void updateVolumePath(List<VolumeObjectTO> volumeTOs) {
for (VolumeObjectTO volume : volumeTOs) {
- if (volume.getPath() != null) {
- VolumeVO volumeVO = volumeDao.findById(volume.getId());
+ if (StringUtils.isAllEmpty(volume.getDataStoreUuid(), volume.getPath(), volume.getChainInfo())) {
+ continue;
+ }
+ VolumeVO volumeVO = volumeDao.findById(volume.getId());
+ if (StringUtils.isNotEmpty(volume.getDataStoreUuid())) {
+ StoragePool pool = primaryDataStoreDao.findPoolByUUID(volume.getDataStoreUuid());
+ if (pool != null && pool.getId() != volumeVO.getPoolId()) {
+ volumeVO.setPoolId(pool.getId());
+ }
+ }
+ if (StringUtils.isNotEmpty(volume.getPath())) {
volumeVO.setPath(volume.getPath());
- volumeVO.setVmSnapshotChainSize(volume.getSize());
- volumeDao.persist(volumeVO);
}
+ if (StringUtils.isNotEmpty(volume.getChainInfo())) {
+ volumeVO.setChainInfo(volume.getChainInfo());
+ }
+ volumeVO.setVmSnapshotChainSize(volume.getSize());
+ volumeDao.persist(volumeVO);
Review Comment:
@DaanHoogland added unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1225585246
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1225645042
@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1222514556
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1222452269
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6643?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6643](https://codecov.io/gh/apache/cloudstack/pull/6643?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4e2f0b0) into [4.17](https://codecov.io/gh/apache/cloudstack/commit/76f52af8f39dc5c397af6f5c3bebf3fc20b62a34?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (76f52af) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## 4.17 #6643 +/- ##
=========================================
Coverage 5.86% 5.86%
- Complexity 3918 3920 +2
=========================================
Files 2451 2451
Lines 242256 242293 +37
Branches 37907 37915 +8
=========================================
+ Hits 14207 14211 +4
- Misses 226479 226512 +33
Partials 1570 1570
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6643?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../storage/vmsnapshot/DefaultVMSnapshotStrategy.java](https://codecov.io/gh/apache/cloudstack/pull/6643/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3N0b3JhZ2Uvc25hcHNob3Qvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svc3RvcmFnZS92bXNuYXBzaG90L0RlZmF1bHRWTVNuYXBzaG90U3RyYXRlZ3kuamF2YQ==) | `50.75% <0.00%> (-1.59%)` | :arrow_down: |
| [...visor/vmware/manager/VmwareStorageManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6643/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy92bXdhcmUvc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci92bXdhcmUvbWFuYWdlci9WbXdhcmVTdG9yYWdlTWFuYWdlckltcGwuamF2YQ==) | `1.06% <0.00%> (-0.02%)` | :arrow_down: |
| [...oud/hypervisor/vmware/resource/VmwareResource.java](https://codecov.io/gh/apache/cloudstack/pull/6643/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy92bXdhcmUvc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci92bXdhcmUvcmVzb3VyY2UvVm13YXJlUmVzb3VyY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...esource/VmwareSecondaryStorageResourceHandler.java](https://codecov.io/gh/apache/cloudstack/pull/6643/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy92bXdhcmUvc3JjL21haW4vamF2YS9jb20vY2xvdWQvc3RvcmFnZS9yZXNvdXJjZS9WbXdhcmVTZWNvbmRhcnlTdG9yYWdlUmVzb3VyY2VIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...cloud/storage/resource/VmwareStorageProcessor.java](https://codecov.io/gh/apache/cloudstack/pull/6643/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy92bXdhcmUvc3JjL21haW4vamF2YS9jb20vY2xvdWQvc3RvcmFnZS9yZXNvdXJjZS9WbXdhcmVTdG9yYWdlUHJvY2Vzc29yLmphdmE=) | `0.32% <0.00%> (+<0.01%)` | :arrow_up: |
| [...oud/hypervisor/vmware/mo/HypervisorHostHelper.java](https://codecov.io/gh/apache/cloudstack/pull/6643/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dm13YXJlLWJhc2Uvc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci92bXdhcmUvbW8vSHlwZXJ2aXNvckhvc3RIZWxwZXIuamF2YQ==) | `15.33% <0.00%> (-0.07%)` | :arrow_down: |
| [...ervisor/kvm/resource/LibvirtComputingResource.java](https://codecov.io/gh/apache/cloudstack/pull/6643/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvTGlidmlydENvbXB1dGluZ1Jlc291cmNlLmphdmE=) | `15.98% <0.00%> (-0.01%)` | :arrow_down: |
| [.../src/main/java/com/cloud/vm/UserVmManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6643/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3ZtL1VzZXJWbU1hbmFnZXJJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ain/java/com/cloud/network/NetworkServiceImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6643/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL25ldHdvcmsvTmV0d29ya1NlcnZpY2VJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...java/com/cloud/tags/TaggedResourceManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6643/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3RhZ3MvVGFnZ2VkUmVzb3VyY2VNYW5hZ2VySW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [2 more](https://codecov.io/gh/apache/cloudstack/pull/6643/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1225708152
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6643)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6643&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6643&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6643&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6643&metric=new_coverage&view=list) [9.2% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6643&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6643&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6643&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6643: [WIP] vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1222119217
@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6643: [WIP] vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1222118670
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1222155226
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 4036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1223655693
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6643)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6643&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6643&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6643&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6643&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6643&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6643&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6643&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1227235427
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6643 (SL-JID-2224)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1223641736
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1225312348
is this ready for review @shwstppr ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1222242867
@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1223642950
@blueorangutan test centos7 vmware-65u2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1229824086
@rohityadavcloud this is being manually tested by @NuxRo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1227303196
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 4055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1227996122
<b>Trillian test result (tid-4760)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43546 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6643-t4760-vmware-67u3.zip
Smoke tests completed. 101 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1227355892
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1227689215
<b>Trillian Build Failed (tid-4764)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1229818121
@shwstppr is this good to merge or are we looking for another review or manual test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1227223224
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1222305267
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6643)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6643&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6643&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6643&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6643&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6643&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6643&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6643&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6643&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#discussion_r953450269
##########
engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/vmsnapshot/DefaultVMSnapshotStrategy.java:
##########
@@ -325,12 +329,24 @@ protected void finalizeRevert(VMSnapshotVO vmSnapshot, List<VolumeObjectTO> volu
private void updateVolumePath(List<VolumeObjectTO> volumeTOs) {
for (VolumeObjectTO volume : volumeTOs) {
- if (volume.getPath() != null) {
- VolumeVO volumeVO = volumeDao.findById(volume.getId());
+ if (StringUtils.isAllEmpty(volume.getDataStoreUuid(), volume.getPath(), volume.getChainInfo())) {
+ continue;
+ }
+ VolumeVO volumeVO = volumeDao.findById(volume.getId());
+ if (StringUtils.isNotEmpty(volume.getDataStoreUuid())) {
+ StoragePool pool = primaryDataStoreDao.findPoolByUUID(volume.getDataStoreUuid());
+ if (pool != null && pool.getId() != volumeVO.getPoolId()) {
+ volumeVO.setPoolId(pool.getId());
+ }
+ }
+ if (StringUtils.isNotEmpty(volume.getPath())) {
volumeVO.setPath(volume.getPath());
- volumeVO.setVmSnapshotChainSize(volume.getSize());
- volumeDao.persist(volumeVO);
}
+ if (StringUtils.isNotEmpty(volume.getChainInfo())) {
+ volumeVO.setChainInfo(volume.getChainInfo());
+ }
+ volumeVO.setVmSnapshotChainSize(volume.getSize());
+ volumeDao.persist(volumeVO);
Review Comment:
More of a general remark than about this piece of code; can these lines be extracted and tested in unit tests. (extracted is maybe not needed in this case, but unit tests would be nice)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1223609219
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1225312961
@DaanHoogland yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1222244161
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6643: vmware: fix vm snapshot with datastore cluster, drs
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6643:
URL: https://github.com/apache/cloudstack/pull/6643#issuecomment-1222241781
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org