You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/08/03 07:41:03 UTC
[GitHub] [incubator-mxnet] cfRod opened a new pull request #20482: [BUGFIX] Fix reuse of primitives for MKLDNN-AArch64. Fixes #20265.
cfRod opened a new pull request #20482:
URL: https://github.com/apache/incubator-mxnet/pull/20482
## Description ##
This fix is a workaround for the accuracy issue in the grouped convolution unit test observed when MXNet is built with Compute Library for Arm Architecture (ACL).
Fixes https://github.com/apache/incubator-mxnet/issues/20265
This change includes:
* Updating MXNet's existing AddSign function to generate unique hashes for MKLDNN-ACL backend.
* Adds a new AddSign overloaded function to generate hashes based on uint64_t type.
* Adding DNNL_AARCH64_USE_ACL definition to CMakeLists.txt
* Adding Crefeda Rodrigues to the contributors list
## Checklist ##
### Essentials ###
- [X] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [X] Changes are complete (i.e. I finished coding on this PR)
- [X] All changes have test coverage
- [X] Code is well-documented
### Changes ###
- [X] Updating MXNet's existing AddSign function to generate unique hashes for MKLDNN-ACL backend.
- [X] Adds a new AddSign overloaded function to generate hashes based on uint64_t type.
- [X] Adding DNNL_AARCH64_USE_ACL definition to CMakeLists.txt
- [X] Adding Crefeda Rodrigues to the contributors list
## Comments ##
- This change is a temporary workaround to resolve the accuracy issue seen test_operator.test_convolution_grouping until future releases of Compute library is compatible with reuse of MKLDNN/oneDNN primitives at the framework-level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] cfRod commented on a change in pull request #20482: [BUGFIX] Fix accuracy issue due to reuse of primitives for MKLDNN-AArch64. Fixes #20265.
Posted by GitBox <gi...@apache.org>.
cfRod commented on a change in pull request #20482:
URL: https://github.com/apache/incubator-mxnet/pull/20482#discussion_r699696406
##########
File path: src/operator/operator_common.h
##########
@@ -620,6 +620,10 @@ class OpSignature {
hash = hash * 2 + arr.dtype();
eles.push_back(arr.dtype());
AddSign(arr.shape());
+#if DNNL_AARCH64_USE_ACL == 1
+ auto ival = reinterpret_cast<const uint64_t>(arr.storage_handle().dptr);
+ AddSign(ival);
+#endif
Review comment:
I checked that this function (arr.IsMKLDNNData()) is called for mkldnn blocked format types https://github.com/apache/incubator-mxnet/blob/7e835a592da902066f2ccb0d74a78adc8e77fdb7/include/mxnet/ndarray.h#L714 and here https://github.com/apache/incubator-mxnet/blob/7e835a592da902066f2ccb0d74a78adc8e77fdb7/src/operator/nn/mkldnn/mkldnn_base.cc#L309 which is not used for ACL builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] cfRod commented on a change in pull request #20482: [BUGFIX] Fix accuracy issue due to reuse of primitives for MKLDNN-AArch64. Fixes #20265.
Posted by GitBox <gi...@apache.org>.
cfRod commented on a change in pull request #20482:
URL: https://github.com/apache/incubator-mxnet/pull/20482#discussion_r702690341
##########
File path: src/operator/operator_common.h
##########
@@ -620,6 +620,10 @@ class OpSignature {
hash = hash * 2 + arr.dtype();
eles.push_back(arr.dtype());
AddSign(arr.shape());
+#if DNNL_AARCH64_USE_ACL == 1
+ auto ival = reinterpret_cast<const uint64_t>(arr.storage_handle().dptr);
+ AddSign(ival);
+#endif
Review comment:
Hi @szha,
As mentioned we have an issue here #20265, where re-using primitives causes accuracy failures for an Arm build of MxNET (which is built with Compute Library for Arm). This is a fix we have added to other frameworks like TensorFlow too, issue here https://github.com/tensorflow/tensorflow/issues/47415 and PR raised here https://github.com/tensorflow/tensorflow/commit/06dd30ef987b5511351e979568d4ad06ccdc2844. Please also refer to the discussion with oneDNN team https://github.com/oneapi-src/oneDNN/issues/1113
for why this fix is necessary. As stated previously, this is a workaround we have had to add at the framework level until this issue can be resolved in future releases of Compute Library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on a change in pull request #20482: [BUGFIX] Fix accuracy issue due to reuse of primitives for MKLDNN-AArch64. Fixes #20265.
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #20482:
URL: https://github.com/apache/incubator-mxnet/pull/20482#discussion_r702974608
##########
File path: src/operator/operator_common.h
##########
@@ -620,6 +620,10 @@ class OpSignature {
hash = hash * 2 + arr.dtype();
eles.push_back(arr.dtype());
AddSign(arr.shape());
+#if DNNL_AARCH64_USE_ACL == 1
+ auto ival = reinterpret_cast<const uint64_t>(arr.storage_handle().dptr);
+ AddSign(ival);
+#endif
Review comment:
OK, thanks for the clarification on the plan to fix. I'm OK with the change and it would be great if you could add a comment in the code on the context and the plan to fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] cfRod commented on a change in pull request #20482: [BUGFIX] Fix accuracy issue due to reuse of primitives for MKLDNN-AArch64. Fixes #20265.
Posted by GitBox <gi...@apache.org>.
cfRod commented on a change in pull request #20482:
URL: https://github.com/apache/incubator-mxnet/pull/20482#discussion_r702690341
##########
File path: src/operator/operator_common.h
##########
@@ -620,6 +620,10 @@ class OpSignature {
hash = hash * 2 + arr.dtype();
eles.push_back(arr.dtype());
AddSign(arr.shape());
+#if DNNL_AARCH64_USE_ACL == 1
+ auto ival = reinterpret_cast<const uint64_t>(arr.storage_handle().dptr);
+ AddSign(ival);
+#endif
Review comment:
Hi @szha,
As mentioned we have an issue here #20265, where re-using primitives causes accuracy failures for an Arm build of MxNET (which is built with Compute Library for Arm). This is a fix we have added to other frameworks like TensorFlow, issue here https://github.com/tensorflow/tensorflow/issues/47415 and PR raised here https://github.com/tensorflow/tensorflow/commit/06dd30ef987b5511351e979568d4ad06ccdc2844. Please also refer to the discussion with the oneDNN team https://github.com/oneapi-src/oneDNN/issues/1113
for why this fix is necessary. As stated previously, this is a workaround we have had to add at the framework level until this issue can be resolved in future releases of Compute Library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] cfRod commented on a change in pull request #20482: [BUGFIX] Fix accuracy issue due to reuse of primitives for MKLDNN-AArch64. Fixes #20265.
Posted by GitBox <gi...@apache.org>.
cfRod commented on a change in pull request #20482:
URL: https://github.com/apache/incubator-mxnet/pull/20482#discussion_r702690341
##########
File path: src/operator/operator_common.h
##########
@@ -620,6 +620,10 @@ class OpSignature {
hash = hash * 2 + arr.dtype();
eles.push_back(arr.dtype());
AddSign(arr.shape());
+#if DNNL_AARCH64_USE_ACL == 1
+ auto ival = reinterpret_cast<const uint64_t>(arr.storage_handle().dptr);
+ AddSign(ival);
+#endif
Review comment:
Hi @szha,
As mentioned we have an issue here #20265, where re-using primitives causes accuracy failures for an Arm build of MxNET (which is built with Compute Library for Arm). This is a fix we have added to other frameworks like TensorFlow, issue here https://github.com/tensorflow/tensorflow/issues/47415 and PR raised here https://github.com/tensorflow/tensorflow/commit/06dd30ef987b5511351e979568d4ad06ccdc2844. Please also refer to the discussion with oneDNN team https://github.com/oneapi-src/oneDNN/issues/1113
for why this fix is necessary. As stated previously, this is a workaround we have had to add at the framework level until this issue can be resolved in future releases of Compute Library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on a change in pull request #20482: [BUGFIX] Fix accuracy issue due to reuse of primitives for MKLDNN-AArch64. Fixes #20265.
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #20482:
URL: https://github.com/apache/incubator-mxnet/pull/20482#discussion_r702479766
##########
File path: src/operator/operator_common.h
##########
@@ -620,6 +620,10 @@ class OpSignature {
hash = hash * 2 + arr.dtype();
eles.push_back(arr.dtype());
AddSign(arr.shape());
+#if DNNL_AARCH64_USE_ACL == 1
+ auto ival = reinterpret_cast<const uint64_t>(arr.storage_handle().dptr);
+ AddSign(ival);
+#endif
Review comment:
I'm also trying to understand why the hash on pointer address is only needed when building ARM64 with oneDNN. Assuming no hash collision, this basically means no reusing, which I'm not sure is the right way to fix it. What's the cause for the wrong reuse?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] cfRod commented on pull request #20482: [BUGFIX] Fix accuracy issue due to reuse of primitives for MKLDNN-AArch64. Fixes #20265.
Posted by GitBox <gi...@apache.org>.
cfRod commented on pull request #20482:
URL: https://github.com/apache/incubator-mxnet/pull/20482#issuecomment-914300840
Hi,
I see that the linting test fails. What linting tool should I use to test this locally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20482: [BUGFIX] Fix reuse of primitives for MKLDNN-AArch64. Fixes #20265.
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20482:
URL: https://github.com/apache/incubator-mxnet/pull/20482#issuecomment-891614290
Hey @cfRod , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [miscellaneous, website, sanity, windows-cpu, unix-cpu, centos-gpu, unix-gpu, clang, centos-cpu, windows-gpu, edge]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #20482: [BUGFIX] Fix accuracy issue due to reuse of primitives for MKLDNN-AArch64. Fixes #20265.
Posted by GitBox <gi...@apache.org>.
szha merged pull request #20482:
URL: https://github.com/apache/incubator-mxnet/pull/20482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on a change in pull request #20482: [BUGFIX] Fix accuracy issue due to reuse of primitives for MKLDNN-AArch64. Fixes #20265.
Posted by GitBox <gi...@apache.org>.
mseth10 commented on a change in pull request #20482:
URL: https://github.com/apache/incubator-mxnet/pull/20482#discussion_r685055450
##########
File path: src/operator/operator_common.h
##########
@@ -620,6 +620,10 @@ class OpSignature {
hash = hash * 2 + arr.dtype();
eles.push_back(arr.dtype());
AddSign(arr.shape());
+#if DNNL_AARCH64_USE_ACL == 1
+ auto ival = reinterpret_cast<const uint64_t>(arr.storage_handle().dptr);
+ AddSign(ival);
+#endif
Review comment:
Why is this only needed when `arr.IsMKLDNNData()` is `False`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on a change in pull request #20482: [BUGFIX] Fix accuracy issue due to reuse of primitives for MKLDNN-AArch64. Fixes #20265.
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #20482:
URL: https://github.com/apache/incubator-mxnet/pull/20482#discussion_r702479766
##########
File path: src/operator/operator_common.h
##########
@@ -620,6 +620,10 @@ class OpSignature {
hash = hash * 2 + arr.dtype();
eles.push_back(arr.dtype());
AddSign(arr.shape());
+#if DNNL_AARCH64_USE_ACL == 1
+ auto ival = reinterpret_cast<const uint64_t>(arr.storage_handle().dptr);
+ AddSign(ival);
+#endif
Review comment:
I'm also trying to understand why the hash on pointer address is only needed when building ARM64 with oneDNN.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #20482: [BUGFIX] Fix accuracy issue due to reuse of primitives for MKLDNN-AArch64. Fixes #20265.
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #20482:
URL: https://github.com/apache/incubator-mxnet/pull/20482#issuecomment-915528567
@cfRod thanks for the workaround!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] cfRod commented on a change in pull request #20482: [BUGFIX] Fix accuracy issue due to reuse of primitives for MKLDNN-AArch64. Fixes #20265.
Posted by GitBox <gi...@apache.org>.
cfRod commented on a change in pull request #20482:
URL: https://github.com/apache/incubator-mxnet/pull/20482#discussion_r702690341
##########
File path: src/operator/operator_common.h
##########
@@ -620,6 +620,10 @@ class OpSignature {
hash = hash * 2 + arr.dtype();
eles.push_back(arr.dtype());
AddSign(arr.shape());
+#if DNNL_AARCH64_USE_ACL == 1
+ auto ival = reinterpret_cast<const uint64_t>(arr.storage_handle().dptr);
+ AddSign(ival);
+#endif
Review comment:
Hi @szha,
As mentioned we have an issue here #2026, where re-using primitives causes accuracy failures for an Arm build of MxNET (which is built with Compute Library for Arm). This is a fix we have added to other frameworks like TensorFlow too, issue here https://github.com/tensorflow/tensorflow/issues/47415 and PR raised here https://github.com/tensorflow/tensorflow/commit/06dd30ef987b5511351e979568d4ad06ccdc2844. Please also refer to the discussion with oneDNN team https://github.com/oneapi-src/oneDNN/issues/1113
for why this fix is necessary. As stated previously, this is a workaround we have had to add at the framework level until this issue can be resolved in future releases of Compute Library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] cfRod commented on pull request #20482: [BUGFIX] Fix accuracy issue due to reuse of primitives for MKLDNN-AArch64. Fixes #20265.
Posted by GitBox <gi...@apache.org>.
cfRod commented on pull request #20482:
URL: https://github.com/apache/incubator-mxnet/pull/20482#issuecomment-893408684
Hi,
I will be away until 20th August. Any issues with this PR I will address when I am back. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] cfRod commented on a change in pull request #20482: [BUGFIX] Fix accuracy issue due to reuse of primitives for MKLDNN-AArch64. Fixes #20265.
Posted by GitBox <gi...@apache.org>.
cfRod commented on a change in pull request #20482:
URL: https://github.com/apache/incubator-mxnet/pull/20482#discussion_r703012638
##########
File path: src/operator/operator_common.h
##########
@@ -620,6 +620,10 @@ class OpSignature {
hash = hash * 2 + arr.dtype();
eles.push_back(arr.dtype());
AddSign(arr.shape());
+#if DNNL_AARCH64_USE_ACL == 1
+ auto ival = reinterpret_cast<const uint64_t>(arr.storage_handle().dptr);
+ AddSign(ival);
+#endif
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] cfRod commented on a change in pull request #20482: [BUGFIX] Fix accuracy issue due to reuse of primitives for MKLDNN-AArch64. Fixes #20265.
Posted by GitBox <gi...@apache.org>.
cfRod commented on a change in pull request #20482:
URL: https://github.com/apache/incubator-mxnet/pull/20482#discussion_r699696406
##########
File path: src/operator/operator_common.h
##########
@@ -620,6 +620,10 @@ class OpSignature {
hash = hash * 2 + arr.dtype();
eles.push_back(arr.dtype());
AddSign(arr.shape());
+#if DNNL_AARCH64_USE_ACL == 1
+ auto ival = reinterpret_cast<const uint64_t>(arr.storage_handle().dptr);
+ AddSign(ival);
+#endif
Review comment:
I checked that this function (arr.IsMKLDNNData()) is called for mkldnn blocked format types https://github.com/apache/incubator-mxnet/blob/7e835a592da902066f2ccb0d74a78adc8e77fdb7/include/mxnet/ndarray.h#L714 and here https://github.com/apache/incubator-mxnet/blob/7e835a592da902066f2ccb0d74a78adc8e77fdb7/src/operator/nn/mkldnn/mkldnn_base.cc#L309 which is not used for ACL builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] cfRod commented on a change in pull request #20482: [BUGFIX] Fix accuracy issue due to reuse of primitives for MKLDNN-AArch64. Fixes #20265.
Posted by GitBox <gi...@apache.org>.
cfRod commented on a change in pull request #20482:
URL: https://github.com/apache/incubator-mxnet/pull/20482#discussion_r702690341
##########
File path: src/operator/operator_common.h
##########
@@ -620,6 +620,10 @@ class OpSignature {
hash = hash * 2 + arr.dtype();
eles.push_back(arr.dtype());
AddSign(arr.shape());
+#if DNNL_AARCH64_USE_ACL == 1
+ auto ival = reinterpret_cast<const uint64_t>(arr.storage_handle().dptr);
+ AddSign(ival);
+#endif
Review comment:
Hi @szha,
As mentioned we have an issue here #2026, where re-using primitives causes accuracy failures for an Arm build of MxNET (which is built with Compute Library for Arm). This is a fix we have added to other frameworks like TensorFlow too, issue here https://github.com/tensorflow/tensorflow/issues/47415 and PR raised here https://github.com/tensorflow/tensorflow/commit/06dd30ef987b5511351e979568d4ad06ccdc2844. Please also refer to the discussion with oneDNN team https://github.com/oneapi-src/oneDNN/issues/1113.
As stated previously, this is a workaround we have had to add at the framework level until this issue can be resolved in future releases of Compute Library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] cfRod commented on a change in pull request #20482: [BUGFIX] Fix accuracy issue due to reuse of primitives for MKLDNN-AArch64. Fixes #20265.
Posted by GitBox <gi...@apache.org>.
cfRod commented on a change in pull request #20482:
URL: https://github.com/apache/incubator-mxnet/pull/20482#discussion_r701686405
##########
File path: src/operator/operator_common.h
##########
@@ -620,6 +620,10 @@ class OpSignature {
hash = hash * 2 + arr.dtype();
eles.push_back(arr.dtype());
AddSign(arr.shape());
+#if DNNL_AARCH64_USE_ACL == 1
+ auto ival = reinterpret_cast<const uint64_t>(arr.storage_handle().dptr);
+ AddSign(ival);
+#endif
Review comment:
@szha, @mseth10, is there anything that needs resolving here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] cfRod edited a comment on pull request #20482: [BUGFIX] Fix accuracy issue due to reuse of primitives for MKLDNN-AArch64. Fixes #20265.
Posted by GitBox <gi...@apache.org>.
cfRod edited a comment on pull request #20482:
URL: https://github.com/apache/incubator-mxnet/pull/20482#issuecomment-914300840
Hi,
I see that the linting test fails. Which linting tool should I use to test this locally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org