You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Frank W. Zammetti (JIRA)" <ji...@apache.org> on 2006/06/20 07:20:17 UTC
[jira] Created: (STR-2889) Updated Checkstyle rules
Updated Checkstyle rules
------------------------
Key: STR-2889
URL: http://issues.apache.org/struts/browse/STR-2889
Project: Struts Action 1
Type: Improvement
Components: Core, Apps, EL, Extras, Faces, Scripting, Taglibs, Tiles
Versions: 1.2 Family, 1.3 Family
Environment: Any
Reporter: Frank W. Zammetti
Argh, I have the priority choices... shouldn't there be something in between minor and major?!? But I digress...
With reference to this thread on the @dev list:
http://mail-archives.apache.org/mod_mbox/struts-dev/200606.mbox/%3c448F56CF.2060207@omnytex.com%3e
Attached is a patch for the Checkstyle rules that eliminates the two things discussed in this thread. It resolves a few hundred exceptions in core alone (350-400, give or take), and should do the same for all other subprojects. There seemed to be a feeling (don't want to say consensus at this point!) that applying this before the next milestone would be acceptable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (STR-2889) Updated Checkstyle rules
Posted by "Frank W. Zammetti (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2889?page=all ]
Frank W. Zammetti updated STR-2889:
-----------------------------------
Attachment: checkstyle_rules.patch
Patch for Checkstylr rules file
> Updated Checkstyle rules
> ------------------------
>
> Key: STR-2889
> URL: http://issues.apache.org/struts/browse/STR-2889
> Project: Struts Action 1
> Type: Improvement
> Components: Core, Apps, EL, Extras, Faces, Scripting, Taglibs, Tiles
> Versions: 1.2 Family, 1.3 Family
> Environment: Any
> Reporter: Frank W. Zammetti
> Attachments: checkstyle_rules.patch
>
> Argh, I have the priority choices... shouldn't there be something in between minor and major?!? But I digress...
> With reference to this thread on the @dev list:
> http://mail-archives.apache.org/mod_mbox/struts-dev/200606.mbox/%3c448F56CF.2060207@omnytex.com%3e
> Attached is a patch for the Checkstyle rules that eliminates the two things discussed in this thread. It resolves a few hundred exceptions in core alone (350-400, give or take), and should do the same for all other subprojects. There seemed to be a feeling (don't want to say consensus at this point!) that applying this before the next milestone would be acceptable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (STR-2889) Updated Checkstyle rules
Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2889?page=all ]
Ted Husted updated STR-2889:
----------------------------
Fix Version: 1.3.5
> Updated Checkstyle rules
> ------------------------
>
> Key: STR-2889
> URL: http://issues.apache.org/struts/browse/STR-2889
> Project: Struts 1
> Type: Improvement
> Components: Apps, Core, EL, Extras, Faces, Scripting, Taglibs, Tiles
> Versions: 1.2 Family, 1.3 Family
> Environment: Any
> Reporter: Frank W. Zammetti
> Fix For: 1.3.5
> Attachments: checkstyle_rules.patch
>
> Argh, I have the priority choices... shouldn't there be something in between minor and major?!? But I digress...
> With reference to this thread on the @dev list:
> http://mail-archives.apache.org/mod_mbox/struts-dev/200606.mbox/%3c448F56CF.2060207@omnytex.com%3e
> Attached is a patch for the Checkstyle rules that eliminates the two things discussed in this thread. It resolves a few hundred exceptions in core alone (350-400, give or take), and should do the same for all other subprojects. There seemed to be a feeling (don't want to say consensus at this point!) that applying this before the next milestone would be acceptable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (STR-2889) Updated Checkstyle rules
Posted by "Wendy Smoak (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2889?page=comments#action_37571 ]
Wendy Smoak commented on STR-2889:
----------------------------------
I deployed a snapshot of struts-build.jar, including Frank's changes.
* http://people.apache.org/maven-snapshot-repository/org/apache/struts/struts-build/
To see the new rules in effect, change the struts-build <extension> version in the struts-action-parent (or other) pom from v1.0.1 to v1.0.2-SNAPSHOT.
(To try out other rule changes locally, modify maven/build/struts_checks.xml, then 'mvn install' from there.
The maven/build directory needs to be organized into src/main/resources, eventually.)
> Updated Checkstyle rules
> ------------------------
>
> Key: STR-2889
> URL: http://issues.apache.org/struts/browse/STR-2889
> Project: Struts Action 1
> Type: Improvement
> Components: Core, Apps, EL, Extras, Faces, Scripting, Taglibs, Tiles
> Versions: 1.2 Family, 1.3 Family
> Environment: Any
> Reporter: Frank W. Zammetti
> Attachments: checkstyle_rules.patch
>
> Argh, I have the priority choices... shouldn't there be something in between minor and major?!? But I digress...
> With reference to this thread on the @dev list:
> http://mail-archives.apache.org/mod_mbox/struts-dev/200606.mbox/%3c448F56CF.2060207@omnytex.com%3e
> Attached is a patch for the Checkstyle rules that eliminates the two things discussed in this thread. It resolves a few hundred exceptions in core alone (350-400, give or take), and should do the same for all other subprojects. There seemed to be a feeling (don't want to say consensus at this point!) that applying this before the next milestone would be acceptable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (STR-2889) Updated Checkstyle rules
Posted by "Frank W. Zammetti (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2889?page=comments#action_37568 ]
Frank W. Zammetti commented on STR-2889:
----------------------------------------
Hehe, late-night typo... That's supposed to be "...I HATE the priority choices..."
> Updated Checkstyle rules
> ------------------------
>
> Key: STR-2889
> URL: http://issues.apache.org/struts/browse/STR-2889
> Project: Struts Action 1
> Type: Improvement
> Components: Core, Apps, EL, Extras, Faces, Scripting, Taglibs, Tiles
> Versions: 1.2 Family, 1.3 Family
> Environment: Any
> Reporter: Frank W. Zammetti
> Attachments: checkstyle_rules.patch
>
> Argh, I have the priority choices... shouldn't there be something in between minor and major?!? But I digress...
> With reference to this thread on the @dev list:
> http://mail-archives.apache.org/mod_mbox/struts-dev/200606.mbox/%3c448F56CF.2060207@omnytex.com%3e
> Attached is a patch for the Checkstyle rules that eliminates the two things discussed in this thread. It resolves a few hundred exceptions in core alone (350-400, give or take), and should do the same for all other subprojects. There seemed to be a feeling (don't want to say consensus at this point!) that applying this before the next milestone would be acceptable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (STR-2889) Updated Checkstyle rules
Posted by "Wendy Smoak (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2889?page=all ]
Wendy Smoak resolved STR-2889:
------------------------------
Resolution: Fixed
Assign To: James Mitchell
http://svn.apache.org/viewvc?rev=415519&view=rev
> Updated Checkstyle rules
> ------------------------
>
> Key: STR-2889
> URL: http://issues.apache.org/struts/browse/STR-2889
> Project: Struts 1
> Type: Improvement
> Components: Apps, Core, EL, Extras, Faces, Scripting, Taglibs, Tiles
> Versions: 1.2 Family, 1.3 Family
> Environment: Any
> Reporter: Frank W. Zammetti
> Assignee: James Mitchell
> Fix For: 1.3.5
> Attachments: checkstyle_rules.patch
>
> Argh, I have the priority choices... shouldn't there be something in between minor and major?!? But I digress...
> With reference to this thread on the @dev list:
> http://mail-archives.apache.org/mod_mbox/struts-dev/200606.mbox/%3c448F56CF.2060207@omnytex.com%3e
> Attached is a patch for the Checkstyle rules that eliminates the two things discussed in this thread. It resolves a few hundred exceptions in core alone (350-400, give or take), and should do the same for all other subprojects. There seemed to be a feeling (don't want to say consensus at this point!) that applying this before the next milestone would be acceptable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (STR-2889) Updated Checkstyle rules
Posted by "James Mitchell (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2889?page=comments#action_37570 ]
James Mitchell commented on STR-2889:
-------------------------------------
Patch applied, however I want to leave this open while more tweaks (if any) are made.
Thanks again.
> Updated Checkstyle rules
> ------------------------
>
> Key: STR-2889
> URL: http://issues.apache.org/struts/browse/STR-2889
> Project: Struts Action 1
> Type: Improvement
> Components: Core, Apps, EL, Extras, Faces, Scripting, Taglibs, Tiles
> Versions: 1.2 Family, 1.3 Family
> Environment: Any
> Reporter: Frank W. Zammetti
> Attachments: checkstyle_rules.patch
>
> Argh, I have the priority choices... shouldn't there be something in between minor and major?!? But I digress...
> With reference to this thread on the @dev list:
> http://mail-archives.apache.org/mod_mbox/struts-dev/200606.mbox/%3c448F56CF.2060207@omnytex.com%3e
> Attached is a patch for the Checkstyle rules that eliminates the two things discussed in this thread. It resolves a few hundred exceptions in core alone (350-400, give or take), and should do the same for all other subprojects. There seemed to be a feeling (don't want to say consensus at this point!) that applying this before the next milestone would be acceptable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (STR-2889) Updated Checkstyle rules
Posted by "James Mitchell (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2889?page=comments#action_37569 ]
James Mitchell commented on STR-2889:
-------------------------------------
Frank, thanks for the patch. By the way, can you turn off 'remove line endings' from your editor? As you probably noticed, it just adds noise to the signal. Nonetheless, thanks again.
--
James Mitchell
> Updated Checkstyle rules
> ------------------------
>
> Key: STR-2889
> URL: http://issues.apache.org/struts/browse/STR-2889
> Project: Struts Action 1
> Type: Improvement
> Components: Core, Apps, EL, Extras, Faces, Scripting, Taglibs, Tiles
> Versions: 1.2 Family, 1.3 Family
> Environment: Any
> Reporter: Frank W. Zammetti
> Attachments: checkstyle_rules.patch
>
> Argh, I have the priority choices... shouldn't there be something in between minor and major?!? But I digress...
> With reference to this thread on the @dev list:
> http://mail-archives.apache.org/mod_mbox/struts-dev/200606.mbox/%3c448F56CF.2060207@omnytex.com%3e
> Attached is a patch for the Checkstyle rules that eliminates the two things discussed in this thread. It resolves a few hundred exceptions in core alone (350-400, give or take), and should do the same for all other subprojects. There seemed to be a feeling (don't want to say consensus at this point!) that applying this before the next milestone would be acceptable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira