You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/01/23 01:06:00 UTC

[GitHub] aaronmarkham opened a new pull request #13963: Fix website error pages

aaronmarkham opened a new pull request #13963: Fix website error pages
URL: https://github.com/apache/incubator-mxnet/pull/13963
 
 
   ## Description ##
   Fixes https://github.com/apache/incubator-mxnet/issues/13959
   This PR creates new error pages, uses some better regex's in the `.htaccess` file, and it provides better artifact handling for the build process.
   
   ### Changes ###
   - [x] Changed the `ErrorDocument` for 404 errors to a local file instead of using a hard-coded link to the error page in production. This is partly why we ended up with a redirect loop. It also had the drawback of giving a 302 redirect header instead of 404. Bots 🤖 don't like that, plus it was probably fooling the broken link checker.
   - [x] Generalized the redirects for pages that should be current (thanks @ddavydenko!).
   - [x] Deleted unnecessary artifacts (index.html was from an old workaround and is not used)
   - [x] Created two new html error pages that don't use relative links to assets as this fails when being loaded dynamically for a 404 message.
   - [x] Updated the Sphinx script to copy these error pages when doing a local build
   - [x] Moved the `mxnet.css` artifact copy to the Sphinx script function to better consolidate artifact and build updates; also this help make sure that any updates to css in your dev version will get applied during a local build AND a full website publish
   
   ## Preview
   
   Aside from the [redirect test links](https://cwiki.apache.org/confluence/display/MXNET/Redirects+on+the+Website), you can try:
   * The new [404 error page](http://34.201.8.176/versions/local_error/error/404.html)
   * The new [API error page](http://34.201.8.176/versions/local_error/error/api.html)
   🌮  Break things with a random URL like: http://34.201.8.176/versions/local_error/tacos
   ❓ Look for an API doc that doesn't exist, like Clojure for v0.11.0: http://34.201.8.176/versions/0.11.0/api/clojure/index.html
   
   Note that I redirect 🌮 requests or anything really in an API subfolder's that is designated in the .htaccess file to the API error, rather than the 404 error. This way we can say, well, maybe it does exist, so try a different version. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services