[GitHub] [calcite] vlsi commented on a change in pull request #1678: [CALCITE-3618] WindowedAggRelSplitter - correct isDependent() checking

[GitBox <gi...@apache.org>]

vlsi commented on a change in pull request #1678: [CALCITE-3618] WindowedAggRelSplitter - correct isDependent() checking
URL: https://github.com/apache/calcite/pull/1678#discussion_r361417509
 
 

 ##########
 File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java
 ##########
 @@ -3820,6 +3820,29 @@ public void checkOrderBy(final boolean desc,
             "deptno=20; empid=200; hire_date=2014-06-12; R=1");
   }
 
+  @Test public void testNestedWin() {
 
 Review comment:
   Frankly speaking I would add the test to a separate (newly created) class like `jdbc.window.WindowFunctionsTest.kt`
   
   JdbcTest is huge, and it is better to refrain adding new tests there.
   It would be better to create a new class that is focused on Window functions.
   
   @ritesh-kapoor , @lxian , WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services