You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hbase.apache.org by Lars George <la...@gmail.com> on 2011/04/20 13:37:14 UTC

Redundant list creation

Hi,

In HRegion.java in trunk, line 3096:

    List<KeyValue> results =  new ArrayList<KeyValue>();
    results = get(get, true);

This should be

    List<KeyValue> results =  get(get, true);

Right?

Lars

Re: Redundant list creation

Posted by Lars George <la...@gmail.com>.

I wish I could help out more but am swamped right now :( Thanks for
handling Stack!

On Wed, Apr 20, 2011 at 9:36 AM, Stack <st...@duboce.net> wrote:
> Fixed, HBASE-3802 (Thanks for reporting it).
>
> On Wed, Apr 20, 2011 at 4:37 AM, Lars George <la...@gmail.com> wrote:
>> Hi,
>>
>> In HRegion.java in trunk, line 3096:
>>
>>    List<KeyValue> results =  new ArrayList<KeyValue>();
>>    results = get(get, true);
>>
>> This should be
>>
>>    List<KeyValue> results =  get(get, true);
>>
>> Right?
>>
>> Lars
>>
>

Re: Redundant list creation

Posted by Stack <st...@duboce.net>.

Fixed, HBASE-3802 (Thanks for reporting it).

On Wed, Apr 20, 2011 at 4:37 AM, Lars George <la...@gmail.com> wrote:
> Hi,
>
> In HRegion.java in trunk, line 3096:
>
>    List<KeyValue> results =  new ArrayList<KeyValue>();
>    results = get(get, true);
>
> This should be
>
>    List<KeyValue> results =  get(get, true);
>
> Right?
>
> Lars
>