You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Benjamin Reed (JIRA)" <ji...@apache.org> on 2010/03/10 02:26:27 UTC
[jira] Created: (ZOOKEEPER-695) Need to remove the lookForLeader
duplicated code in LENonTerminateTest
Need to remove the lookForLeader duplicated code in LENonTerminateTest
----------------------------------------------------------------------
Key: ZOOKEEPER-695
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-695
Project: Zookeeper
Issue Type: Bug
Reporter: Benjamin Reed
To do the LENonTerminateTest we need to hook into the lookForLeader code. In the last release we did this by duplicating the code. This needs to be cleaned up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-695) Need to remove the lookForLeader
duplicated code in LENonTerminateTest
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843468#action_12843468 ]
Flavio Paiva Junqueira commented on ZOOKEEPER-695:
--------------------------------------------------
Henry asked this question before in ZOOKEEPER-684 and a patch was committed before I had a chance to respond. The socket timeout I'm referring to is in LeaderElection.java:136.
> Need to remove the lookForLeader duplicated code in LENonTerminateTest
> ----------------------------------------------------------------------
>
> Key: ZOOKEEPER-695
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-695
> Project: Zookeeper
> Issue Type: Bug
> Reporter: Benjamin Reed
>
> To do the LENonTerminateTest we need to hook into the lookForLeader code. In the last release we did this by duplicating the code. This needs to be cleaned up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-695) Need to remove the lookForLeader
duplicated code in LENonTerminateTest
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843700#action_12843700 ]
Flavio Paiva Junqueira commented on ZOOKEEPER-695:
--------------------------------------------------
I was trying to draft a response and then I realized that I don't think we need a timeout to get the race I was thinking about, so I think you're right, Henry. In fact if there had been a timeout in that log, there would be a log message saying that the response was short, and I can't find such a message.
> Need to remove the lookForLeader duplicated code in LENonTerminateTest
> ----------------------------------------------------------------------
>
> Key: ZOOKEEPER-695
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-695
> Project: Zookeeper
> Issue Type: Bug
> Reporter: Benjamin Reed
>
> To do the LENonTerminateTest we need to hook into the lookForLeader code. In the last release we did this by duplicating the code. This needs to be cleaned up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-695) Need to remove the lookForLeader
duplicated code in LENonTerminateTest
Posted by "Henry Robinson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843684#action_12843684 ]
Henry Robinson commented on ZOOKEEPER-695:
------------------------------------------
Flavio -
I believe that timeouts can be an issue, and that 200ms is maybe a bit aggressive. I'm not sure that was the problem in ZOOKEEPER-684; I really think the issue there was the race on doing a round of voting in lockstep.
It might make sense to increase the timeout in the test code - let's do that as part of this JIRA for 3.4.0.
Henry
> Need to remove the lookForLeader duplicated code in LENonTerminateTest
> ----------------------------------------------------------------------
>
> Key: ZOOKEEPER-695
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-695
> Project: Zookeeper
> Issue Type: Bug
> Reporter: Benjamin Reed
>
> To do the LENonTerminateTest we need to hook into the lookForLeader code. In the last release we did this by duplicating the code. This needs to be cleaned up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.