You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Felix Abecassis <fa...@nvidia.com> on 2015/09/22 04:14:15 UTC
Re: Review Request 38279: Add a new callback enabling custom resource
discovery logic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38279/
-----------------------------------------------------------
(Updated Sept. 22, 2015, 2:14 a.m.)
Review request for mesos, Connor Doyle and Niklas Nielsen.
Summary (updated)
-----------------
Add a new callback enabling custom resource discovery logic
Bugs: MESOS-3366
https://issues.apache.org/jira/browse/MESOS-3366
Repository: mesos
Description
-------
First API draft for MESOS-3366.
1) Only supports resources for now, we can add another hook for attributes with a very similar code.
2) The callback currently receives the full SlaveInfo structure and construct a new Resources object.
3) If there is multiple callbacks, each callback will see the changes made by previous callbacks and are free to override or merge the detected resources as they see fit.
Diffs
-----
include/mesos/hook.hpp 2353602
src/examples/test_hook_module.cpp 0dc74d6
src/hook/manager.hpp a517c05
src/hook/manager.cpp 691976e
src/slave/slave.cpp 29865ec
src/tests/hook_tests.cpp b23a587
Diff: https://reviews.apache.org/r/38279/diff/
Testing
-------
make clean && make && make check
Thanks,
Felix Abecassis
Re: Review Request 38279: Add a new callback enabling custom resource
discovery logic
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38279/#review102137
-----------------------------------------------------------
Ship it!
I'll go ahead and fix the last two issues before committing. Thanks for your patience Felix!
include/mesos/hook.hpp (lines 117 - 121)
<https://reviews.apache.org/r/38279/#comment159703>
Will wrap at 80 cols after recent style guide change.
include/mesos/hook.hpp (line 122)
<https://reviews.apache.org/r/38279/#comment159700>
Changing 'InitializationResourcesDecorator' -> 'ResourcesDecorator'
- Niklas Nielsen
On Sept. 21, 2015, 7:14 p.m., Felix Abecassis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38279/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2015, 7:14 p.m.)
>
>
> Review request for mesos, Connor Doyle and Niklas Nielsen.
>
>
> Bugs: MESOS-3366
> https://issues.apache.org/jira/browse/MESOS-3366
>
>
> Repository: mesos
>
>
> Description
> -------
>
> First API draft for MESOS-3366.
>
> 1) Only supports resources for now, we can add another hook for attributes with a very similar code.
> 2) The callback currently receives the full SlaveInfo structure and construct a new Resources object.
> 3) If there is multiple callbacks, each callback will see the changes made by previous callbacks and are free to override or merge the detected resources as they see fit.
>
>
> Diffs
> -----
>
> include/mesos/hook.hpp 2353602
> src/examples/test_hook_module.cpp 0dc74d6
> src/hook/manager.hpp a517c05
> src/hook/manager.cpp 691976e
> src/slave/slave.cpp 29865ec
> src/tests/hook_tests.cpp b23a587
>
> Diff: https://reviews.apache.org/r/38279/diff/
>
>
> Testing
> -------
>
> make clean && make && make check
>
>
> Thanks,
>
> Felix Abecassis
>
>