[GitHub] [arrow-site] lidavidm commented on a diff in pull request #299: MINOR: [Website] Reword ADBC announcement

[GitBox <gi...@apache.org>]

lidavidm commented on code in PR #299:
URL: https://github.com/apache/arrow-site/pull/299#discussion_r1072916029


##########
_posts/2023-01-05-introducing-arrow-adbc.md:
##########
@@ -66,10 +66,10 @@ Developers have a few options:
   Libraries like [Turbodbc][turbodbc] and [arrow-jdbc][arrow-jdbc] handle row-to-columnar conversions for clients.
   But this doesn't fundamentally solve the problem.
   Unnecessary data conversions are still required.
-- *Use vendor-specific protocols*.
-  For some databases, applications can use a database-specific protocol or SDK to directly get Arrow data.
-  For example, applications could use Dremio via [Arrow Flight SQL][flight-sql].
-  But client applications that want to support multiple database vendors would need to integrate with each of them.
+- *Directly use database protocols*.
+  For some databases, applications can use a database protocol or SDK to directly get Arrow data.
+  For example, applications could use be written with [Arrow Flight SQL][flight-sql] to connect to Dremio and other databases that support the Flight SQL protocol.

Review Comment:
   ```suggestion
     For example, applications could use [Arrow Flight SQL][flight-sql] to connect to Dremio and other databases that support the Flight SQL protocol.
   ```
   
   (If you want, I think it's fair to link "Dremio" to the website as well.)



##########
_posts/2023-01-05-introducing-arrow-adbc.md:
##########
@@ -144,7 +144,7 @@ ADBC fills a specific niche that related projects do not address. It is both:
     <tr>
       <th></th>
       <th class="align-top" style="width: 40%" scope="col">Vendor-neutral (database APIs)</th>
-      <th class="align-top" style="width: 40%" scope="col">Vendor-specific (database protocols)</th>
+      <th class="align-top" style="width: 40%" scope="col">Database protocols</th>

Review Comment:
   I think it's still fair to call them vendor-specific; after all, multiple databases also use the PostgreSQL protocol (it just doesn't have a generic name). Maybe "varies by vendor (database protocols)"?



##########
_posts/2023-01-05-introducing-arrow-adbc.md:
##########
@@ -66,10 +66,10 @@ Developers have a few options:
   Libraries like [Turbodbc][turbodbc] and [arrow-jdbc][arrow-jdbc] handle row-to-columnar conversions for clients.
   But this doesn't fundamentally solve the problem.
   Unnecessary data conversions are still required.
-- *Use vendor-specific protocols*.
-  For some databases, applications can use a database-specific protocol or SDK to directly get Arrow data.
-  For example, applications could use Dremio via [Arrow Flight SQL][flight-sql].
-  But client applications that want to support multiple database vendors would need to integrate with each of them.
+- *Directly use database protocols*.
+  For some databases, applications can use a database protocol or SDK to directly get Arrow data.
+  For example, applications could use be written with [Arrow Flight SQL][flight-sql] to connect to Dremio and other databases that support the Flight SQL protocol.
+  But not all databases support the Flight SQL protocol. An example is Google BigQuery, which has a separate SDK that returns Arrow data. In this case, client applications that want to support additional protocols would need to integrate with each of them.

Review Comment:
   ```suggestion
     But not all databases support Flight SQL, even if they support Arrow data. An example is Google BigQuery, which has a separate SDK that returns Arrow data. In this case, client applications that want to support additional databases would need to integrate with each of their protocols.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org