You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Uwe Schindler (JIRA)" <ji...@apache.org> on 2009/08/10 16:22:14 UTC
[jira] Issue Comment Edited: (LUCENE-1794) implement
reusableTokenStream for all contrib analyzers
[ https://issues.apache.org/jira/browse/LUCENE-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741337#action_12741337 ]
Uwe Schindler edited comment on LUCENE-1794 at 8/10/09 7:20 AM:
----------------------------------------------------------------
{quote}
different things need to happen here: for example Thai and Smart Chinese have filters that keep state and require a reset(). But i don't know, seems like it could be factored into Analyzer and reset() called on both tokenizer and filters...
I am trying to imagine a situation where refactoring this kind of thing would prevent some flexibility, but i think if tokenstreams keep state in some wierd way they should implement reset() for this purpose.
{quote}
reset() is always called by IndexWriter before consuming the TokenStream; end() is called as last operation on the TokenStream.
And each TokenFilter should for sure pass the call also to the input TokenStream... The default impl does this.
was (Author: thetaphi):
{quote}
different things need to happen here: for example Thai and Smart Chinese have filters that keep state and require a reset(). But i don't know, seems like it could be factored into Analyzer and reset() called on both tokenizer and filters...
I am trying to imagine a situation where refactoring this kind of thing would prevent some flexibility, but i think if tokenstreams keep state in some wierd way they should implement reset() for this purpose.
{quote}
reset() is always called by IndexWriter before consuming the TokenStream; end() is called as last operation on the TokenStream.
> implement reusableTokenStream for all contrib analyzers
> -------------------------------------------------------
>
> Key: LUCENE-1794
> URL: https://issues.apache.org/jira/browse/LUCENE-1794
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/analyzers
> Reporter: Robert Muir
> Assignee: Robert Muir
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1794.patch, LUCENE-1794.patch
>
>
> most contrib analyzers do not have an impl for reusableTokenStream
> regardless of how expensive the back compat reflection is for indexing speed, I think we should do this to mitigate any performance costs. hey, overall it might even be an improvement!
> the back compat code for non-final analyzers is already in place so this is easy money in my opinion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org