You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2011/05/30 16:07:47 UTC
[jira] [Created] (HBASE-3934) MemStoreFlusher.getMemStoreLimit()
doesn't honor defaultLimit
MemStoreFlusher.getMemStoreLimit() doesn't honor defaultLimit
-------------------------------------------------------------
Key: HBASE-3934
URL: https://issues.apache.org/jira/browse/HBASE-3934
Project: HBase
Issue Type: Bug
Reporter: Ted Yu
>From Lars George:
See below from MemStoreFlusher.java (trunk):
{code}
static long getMemStoreLimit(final long max, final float limit,
final float defaultLimit) {
if (limit >= 0.9f || limit < 0.1f) {
LOG.warn("Setting global memstore limit to default of " + defaultLimit +
" because supplied value outside allowed range of 0.1 -> 0.9");
}
return (long)(max * limit);
}
{code}
The log message says it is using defaultLimit, but the code is not.
Should we fix either?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-3934) MemStoreFlusher.getMemStoreLimit()
doesn't honor defaultLimit
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-3934.
--------------------------
Resolution: Fixed
Fix Version/s: 0.90.4
Hadoop Flags: [Reviewed]
Committed branch and trunk. Thanks for the patch Ted.
> MemStoreFlusher.getMemStoreLimit() doesn't honor defaultLimit
> -------------------------------------------------------------
>
> Key: HBASE-3934
> URL: https://issues.apache.org/jira/browse/HBASE-3934
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Fix For: 0.90.4
>
> Attachments: 3934.txt
>
>
> From Lars George:
> See below from MemStoreFlusher.java (trunk):
> {code}
> static long getMemStoreLimit(final long max, final float limit,
> final float defaultLimit) {
> if (limit >= 0.9f || limit < 0.1f) {
> LOG.warn("Setting global memstore limit to default of " + defaultLimit +
> " because supplied value outside allowed range of 0.1 -> 0.9");
> }
> return (long)(max * limit);
> }
> {code}
> The log message says it is using defaultLimit, but the code is not.
> Should we fix either?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3934) MemStoreFlusher.getMemStoreLimit()
doesn't honor defaultLimit
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042558#comment-13042558 ]
Hudson commented on HBASE-3934:
-------------------------------
Integrated in HBase-TRUNK #1950 (See [https://builds.apache.org/hudson/job/HBase-TRUNK/1950/])
> MemStoreFlusher.getMemStoreLimit() doesn't honor defaultLimit
> -------------------------------------------------------------
>
> Key: HBASE-3934
> URL: https://issues.apache.org/jira/browse/HBASE-3934
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Fix For: 0.90.4
>
> Attachments: 3934.txt
>
>
> From Lars George:
> See below from MemStoreFlusher.java (trunk):
> {code}
> static long getMemStoreLimit(final long max, final float limit,
> final float defaultLimit) {
> if (limit >= 0.9f || limit < 0.1f) {
> LOG.warn("Setting global memstore limit to default of " + defaultLimit +
> " because supplied value outside allowed range of 0.1 -> 0.9");
> }
> return (long)(max * limit);
> }
> {code}
> The log message says it is using defaultLimit, but the code is not.
> Should we fix either?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-3934) MemStoreFlusher.getMemStoreLimit()
doesn't honor defaultLimit
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu reassigned HBASE-3934:
-----------------------------
Assignee: Ted Yu
> MemStoreFlusher.getMemStoreLimit() doesn't honor defaultLimit
> -------------------------------------------------------------
>
> Key: HBASE-3934
> URL: https://issues.apache.org/jira/browse/HBASE-3934
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3934.txt
>
>
> From Lars George:
> See below from MemStoreFlusher.java (trunk):
> {code}
> static long getMemStoreLimit(final long max, final float limit,
> final float defaultLimit) {
> if (limit >= 0.9f || limit < 0.1f) {
> LOG.warn("Setting global memstore limit to default of " + defaultLimit +
> " because supplied value outside allowed range of 0.1 -> 0.9");
> }
> return (long)(max * limit);
> }
> {code}
> The log message says it is using defaultLimit, but the code is not.
> Should we fix either?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3934) MemStoreFlusher.getMemStoreLimit()
doesn't honor defaultLimit
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-3934:
--------------------------
Attachment: 3934.txt
> MemStoreFlusher.getMemStoreLimit() doesn't honor defaultLimit
> -------------------------------------------------------------
>
> Key: HBASE-3934
> URL: https://issues.apache.org/jira/browse/HBASE-3934
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3934.txt
>
>
> From Lars George:
> See below from MemStoreFlusher.java (trunk):
> {code}
> static long getMemStoreLimit(final long max, final float limit,
> final float defaultLimit) {
> if (limit >= 0.9f || limit < 0.1f) {
> LOG.warn("Setting global memstore limit to default of " + defaultLimit +
> " because supplied value outside allowed range of 0.1 -> 0.9");
> }
> return (long)(max * limit);
> }
> {code}
> The log message says it is using defaultLimit, but the code is not.
> Should we fix either?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira