You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by mcgilman <gi...@git.apache.org> on 2018/10/10 19:08:05 UTC

[GitHub] nifi pull request #3037: NIFI-5645: Auto reconnect ConsumeWindowsEventLog

Github user mcgilman commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/3037#discussion_r224205359
  
    --- Diff: nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log/ConsumeWindowsEventLog.java ---
    @@ -199,6 +230,8 @@ private String subscribe(ProcessContext context) throws URISyntaxException {
     
             subscriptionHandle = wEvtApi.EvtSubscribe(null, null, channel, query, null, null,
                     evtSubscribeCallback, WEvtApi.EvtSubscribeFlags.SUBSCRIBE_TO_FUTURE | WEvtApi.EvtSubscribeFlags.EVT_SUBSCRIBE_STRICT);
    +        lastActivityTimestamp = System.currentTimeMillis();
    --- End diff --
    
    Just wanted to clarify the logic here... Do we want to update the `lastActivityTimestamp` when the client was unable to subscribe? Could that lead to premature reconnection later?


---