You are viewing a plain text version of this content. The canonical link for it is here.
Posted to rampart-dev@ws.apache.org by ka...@apache.org on 2007/06/08 07:36:58 UTC

svn commit: r545424 - in /webservices/rampart/trunk/c/src/omxmlsec: axiom.c signature.c

Author: kaushalye
Date: Thu Jun  7 22:36:58 2007
New Revision: 545424

URL: http://svn.apache.org/viewvc?view=rev&rev=545424
Log:
Fising memry leak in Signature

Modified:
    webservices/rampart/trunk/c/src/omxmlsec/axiom.c
    webservices/rampart/trunk/c/src/omxmlsec/signature.c

Modified: webservices/rampart/trunk/c/src/omxmlsec/axiom.c
URL: http://svn.apache.org/viewvc/webservices/rampart/trunk/c/src/omxmlsec/axiom.c?view=diff&rev=545424&r1=545423&r2=545424
==============================================================================
--- webservices/rampart/trunk/c/src/omxmlsec/axiom.c (original)
+++ webservices/rampart/trunk/c/src/omxmlsec/axiom.c Thu Jun  7 22:36:58 2007
@@ -237,7 +237,6 @@
 AXIS2_EXTERN axiom_node_t *AXIS2_CALL
 oxs_axiom_deserialize_node(const axutil_env_t *env,  axis2_char_t* buffer)
 {
-
     axiom_document_t *doc = NULL;
     axiom_stax_builder_t *builder = NULL;
     axiom_xml_reader_t *reader = NULL;
@@ -283,6 +282,7 @@
     }
     axiom_xml_reader_free(reader, env);
     reader = NULL;
+    
     return node;
 }
 

Modified: webservices/rampart/trunk/c/src/omxmlsec/signature.c
URL: http://svn.apache.org/viewvc/webservices/rampart/trunk/c/src/omxmlsec/signature.c?view=diff&rev=545424&r1=545423&r2=545424
==============================================================================
--- webservices/rampart/trunk/c/src/omxmlsec/signature.c (original)
+++ webservices/rampart/trunk/c/src/omxmlsec/signature.c Thu Jun  7 22:36:58 2007
@@ -60,6 +60,8 @@
     status = oxs_buffer_populate(output, env, (unsigned char*)axutil_strdup(env, encoded_str), encodedlen);
 
     /*Free signed_result_buf*/
+    oxs_buffer_free(signed_result_buf, env);
+    signed_result_buf = NULL;
 
     return AXIS2_SUCCESS;
 }
@@ -143,10 +145,14 @@
     if(AXIS2_SUCCESS != status){
         /*Error in signature processing*/
         oxs_error(env, ERROR_LOCATION, OXS_ERROR_SIG_VERIFICATION_FAILED,"Signature verification FAILED.");
+        oxs_buffer_free(in_buf, env);
+        in_buf = NULL;
         return AXIS2_FAILURE;
     }else{
 
         AXIS2_LOG_INFO(env->log, "[oxs][sig] Signature verification SUCCESS " );
+        oxs_buffer_free(in_buf, env);
+        in_buf = NULL;
         return AXIS2_SUCCESS;
     }