[GitHub] [inlong] xuesongxs commented on pull request #5831: [INLONG-5830][DataProxy] Fix required parameter topic exception

[GitBox <gi...@apache.org>]

xuesongxs commented on PR #5831:
URL: https://github.com/apache/inlong/pull/5831#issuecomment-1240351032

   Use the topic in the topics.properties file to handle the message, instead of using the topic field in the dataproxy-mulit-pulsar-http-example.conf file.
   
   From: Goson Zhang
   Date: 2022-09-08 15:26
   To: apache/inlong
   CC: xuesongxs; Author
   Subject: Re: [apache/inlong] [INLONG-5830][DataProxy] Fix required parameter topic exception (PR #5831)
   @gosonzhang commented on this pull request.
   
   
   In inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/http/HttpBaseSource.java:
   > @@ -117,10 +117,7 @@ public void configure(Context context) {
    
            topic = context.getString(ConfigConstants.TOPIC);
            attr = context.getString(ConfigConstants.ATTR);
   -        Configurables.ensureRequiredNonNull(context, ConfigConstants.TOPIC, ConfigConstants.ATTR);
   
   How to handle the message if the topic is empty and not checked?
   —
   Reply to this email directly, view it on GitHub, or unsubscribe.
   You are receiving this because you authored the thread.Message ID: ***@***.***>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org