You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "fuchanghai (via GitHub)" <gi...@apache.org> on 2023/11/25 03:33:08 UTC

Re: [PR] [Fix-15029][master] fix subprocess lost output parameter which is not direct connectioned to subProcess [dolphinscheduler]

fuchanghai commented on code in PR #15031:
URL: https://github.com/apache/dolphinscheduler/pull/15031#discussion_r1404711107


##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/task/subworkflow/SubWorkflowAsyncTaskExecuteFunction.java:
##########
@@ -55,6 +55,8 @@ public SubWorkflowAsyncTaskExecuteFunction(TaskExecutionContext taskExecutionCon
         }
         subWorkflowInstance = processInstanceDao.queryById(subWorkflowInstance.getId());
         if (subWorkflowInstance != null && subWorkflowInstance.getState().isFinished()) {
+            // update the varPool of sub workflow
+            taskExecutionContext.setVarPool(subWorkflowInstance.getVarPool());

Review Comment:
   This block is a method to obtain status. Why do you need to set variables here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org