[GitHub] [hive] kgyrtkirk commented on a change in pull request #2109: sq_check_count returns boolean

[GitBox <gi...@apache.org>]

kgyrtkirk commented on a change in pull request #2109:
URL: https://github.com/apache/hive/pull/2109#discussion_r601310439



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSQCountCheck.java
##########
@@ -26,22 +26,24 @@
 import org.apache.hadoop.hive.ql.exec.vector.expressions.gen.FuncAbsDoubleToDouble;
 import org.apache.hadoop.hive.ql.exec.vector.expressions.gen.FuncAbsLongToLong;
 import org.apache.hadoop.hive.ql.metadata.HiveException;
+import org.apache.hadoop.hive.ql.udf.UDFType;
 import org.apache.hadoop.hive.serde2.objectinspector.ObjectInspector;
 import org.apache.hadoop.hive.serde2.objectinspector.ObjectInspectorConverters;
 import org.apache.hadoop.hive.serde2.objectinspector.ObjectInspectorConverters.Converter;
 import org.apache.hadoop.hive.serde2.objectinspector.primitive.PrimitiveObjectInspectorFactory;
-import org.apache.hadoop.io.LongWritable;
+import org.apache.hadoop.io.BooleanWritable;
 
 /**
  * GenericUDFAbs.
  *
  */
+@UDFType(deterministic = false)
 @Description(name = "sq_count_check",
     value = "_FUNC_(x) - Internal check on scalar subquery expression to make sure atmost one row is returned",
     extended = "For internal use only")
 @VectorizedExpressions({FuncAbsLongToLong.class, FuncAbsDoubleToDouble.class, FuncAbsDecimalToDecimal.class})

Review comment:
       I don't think these Vectorized functions will work instead of this UDF 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org