[GitHub] [calcite] wenhuitang commented on a change in pull request #1273: [hotfix]fix the javadoc typo in RelOptRule.java.(Wenhui Tang)

[GitBox <gi...@apache.org>]

wenhuitang commented on a change in pull request #1273: [hotfix]fix the javadoc typo in RelOptRule.java.(Wenhui Tang)
URL: https://github.com/apache/calcite/pull/1273#discussion_r296216907
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/plan/RelOptRule.java
 ##########
 @@ -536,7 +536,7 @@ public RelTrait getOutTrait() {
    * Returns the description of this rule.
    *
    * <p>It must be unique (for rules that are not equal) and must consist of
-   * only the characters A-Z, a-z, 0-9, '_', '.', '(', ')'. It must start with
+   * only the characters A-Z, a-z, 0-9, '-', '_', '.', '(', ')'. It must start with
 
 Review comment:
   > This is too small change for a PR, can we just merge it into another bigger one ?
   
   Yes, I have a pull request for issue(https://issues.apache.org/jira/browse/CALCITE-3136?filter=-1), I can merge this PR to https://github.com/apache/calcite/pull/1275. By the way, @danny0405 do you have time to have a look at https://github.com/apache/calcite/pull/1275. Thanks a lot.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services