You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@parquet.apache.org by "OmBiradar (via GitHub)" <gi...@apache.org> on 2026/03/12 11:28:27 UTC
[PR] Fix formatting in `parquet.thrift` file (trailing spaces) [parquet-format]
OmBiradar opened a new pull request, #558:
URL: https://github.com/apache/parquet-format/pull/558
There were many trailing spaces here and there,
they have been removed.
<!--
Thanks for opening a pull request!
If you're new to Parquet-Format, information on how to contribute can be found here: https://parquet.apache.org/docs/contribution-guidelines/contributing
Please open a GitHub issue for this pull request: https://github.com/apache/parquet-format/issues/new/choose
and format pull request title as below:
GH-${GITHUB_ISSUE_ID}: ${SUMMARY}
or simply use the title below if it is a minor issue:
MINOR: ${SUMMARY}
-->
### Rationale for this change
### What changes are included in this PR?
### Do these changes have PoC implementations?
<!-- Please uncomment the line below and replace ${GITHUB_ISSUE_ID} with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] MINOR: Fix formatting in `parquet.thrift` file (trailing spaces) [parquet-format]
Posted by "OmBiradar (via GitHub)" <gi...@apache.org>.
OmBiradar commented on PR #558:
URL: https://github.com/apache/parquet-format/pull/558#issuecomment-4047933308
What if we add a new '.git-blame-ignore-revs' file that will help avoid these formatting/linting related commits to interfear with the 'git blame'
https://www.git-tower.com/blog/how-to-exclude-commits-from-git-blame#:~:text=You%20can%20do%20this%20by,ignoreRevsFile%20configuration%20option.&text=With%20this%20configuration%20in%20place,blame%2Dignore%2Drevs%20file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] MINOR: Fix formatting in `parquet.thrift` file (trailing spaces) [parquet-format]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #558:
URL: https://github.com/apache/parquet-format/pull/558#issuecomment-4046705296
(I'll leave this open for a while to make sure other committers have a chance to review if they would like)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] MINOR: Fix formatting in `parquet.thrift` file (trailing spaces) [parquet-format]
Posted by "OmBiradar (via GitHub)" <gi...@apache.org>.
OmBiradar commented on PR #558:
URL: https://github.com/apache/parquet-format/pull/558#issuecomment-4046011328
original issue - [apache-arrow-issue-49501](https://github.com/apache/arrow/issues/49501)
requesting your review @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] MINOR: Fix formatting in `parquet.thrift` file (trailing spaces) [parquet-format]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #558:
URL: https://github.com/apache/parquet-format/pull/558#issuecomment-4047724872
> +1 from me. I know the intention is good but I don't know if anyone really cares about the original commit history.
The commit history will be retained, but just using `git blame` directly will be harder to interpret (will require more archeology)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] MINOR: Fix formatting in `parquet.thrift` file (trailing spaces) [parquet-format]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #558:
URL: https://github.com/apache/parquet-format/pull/558#issuecomment-4047699529
> @alamb @wgtmac
>
> Should I add a new CI task to check the linting in this PR itself?
No, if you want to propose a new CI please use a new PR. I am not sure we are likely to add new CI 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] MINOR: Fix formatting in `parquet.thrift` file (trailing spaces) [parquet-format]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #558:
URL: https://github.com/apache/parquet-format/pull/558#discussion_r2961436412
##########
src/main/thrift/parquet.thrift:
##########
@@ -280,7 +280,7 @@ struct Statistics {
*/
1: optional binary max;
2: optional binary min;
- /**
+ /**
Review Comment:
using `git blame -w` does indeed correctly ignore whitespace differences:
```shell
git blame -w src/main/thrift/parquet.thrift
...
2c4ada8e src/thrift/parquet.thrift (julien 2013-09-17 18:21:15 -0700 267) struct Statistics {
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17 11:23:41 -0700 268) /**
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17 11:23:41 -0700 269) * DEPRECATED: min and max value of the column. Use min_value and max_value.
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17 11:23:41 -0700 270) *
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17 11:23:41 -0700 271) * Values are encoded using PLAIN encoding, except that variable-length byte
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17 11:23:41 -0700 272) * arrays do not include a length prefix.
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17 11:23:41 -0700 273) *
bef54389 src/main/thrift/parquet.thrift (Zoltan Ivanfi 2017-10-06 16:38:53 -0700 274) * These fields encode min and max values determined by signed comparison
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17 11:23:41 -0700 275) * only. New files should use the correct order for a column's logical type
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17 11:23:41 -0700 276) * and store the values in the min_value and max_value fields.
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17 11:23:41 -0700 277) *
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17 11:23:41 -0700 278) * To support older readers, these may be set when the column order is
bef54389 src/main/thrift/parquet.thrift (Zoltan Ivanfi 2017-10-06 16:38:53 -0700 279) * signed.
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17 11:23:41 -0700 280) */
2c4ada8e src/thrift/parquet.thrift (julien 2013-09-17 18:21:15 -0700 281) 1: optional binary max;
2c4ada8e src/thrift/parquet.thrift (julien 2013-09-17 18:21:15 -0700 282) 2: optional binary min;
db687874 src/main/thrift/parquet.thrift (mwish 2024-08-23 15:30:20 +0800 283) /**
db687874 src/main/thrift/parquet.thrift (mwish 2024-08-23 15:30:20 +0800 284) * Count of null values in the column.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] MINOR: Fix formatting in `parquet.thrift` file (trailing spaces) [parquet-format]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #558:
URL: https://github.com/apache/parquet-format/pull/558#issuecomment-4091728502
Thanks again for the help cleaning this up @OmBiradar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] MINOR: Fix formatting in `parquet.thrift` file (trailing spaces) [parquet-format]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #558:
URL: https://github.com/apache/parquet-format/pull/558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] MINOR: Fix formatting in `parquet.thrift` file (trailing spaces) [parquet-format]
Posted by "OmBiradar (via GitHub)" <gi...@apache.org>.
OmBiradar commented on PR #558:
URL: https://github.com/apache/parquet-format/pull/558#issuecomment-4047248609
@alamb @wgtmac
Should I add a new CI pipeline to check the linting in this PR itself?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org