[jira] [Commented] (HIVE-8806) Potential null dereference in Metrics#incrementCounter()

["Hive QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-8806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228712#comment-14228712 ] 

Hive QA commented on HIVE-8806:
-------------------------------



{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12684234/HIVE-8806.1.patch

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 6694 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_vector_decimal_aggregate
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_mapjoin_mapjoin
{noformat}

Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/1936/testReport
Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/1936/console
Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-1936/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12684234 - PreCommit-HIVE-TRUNK-Build

> Potential null dereference in Metrics#incrementCounter()
> --------------------------------------------------------
>
>                 Key: HIVE-8806
>                 URL: https://issues.apache.org/jira/browse/HIVE-8806
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>         Attachments: HIVE-8806.1.patch
>
>
> {code}
>       if (!metrics.hasKey(name)) {
>         value = Long.valueOf(increment);
>         set(name, value);
>       } else {
>         value = ((Long)get(name)) + increment;
>         set(name, value);
>       }
> {code}
> In the else block, if get(name) returns null, unboxing null object would lead to exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)