[GitHub] [lucene] mayya-sharipova commented on pull request #324: LUCENE-10126: Fix competitiveIterator wrongly skip documents

[GitBox <gi...@apache.org>]

mayya-sharipova commented on pull request #324:
URL: https://github.com/apache/lucene/pull/324#issuecomment-929275183


   @dnhatn Thanks for spotting this bug. I was wondering if instead of `NumericComparator`, we should make this change in `DefaultBulkScorer::score(LeafCollector collector, Bits acceptDocs, int min, int max)`. Two reasons for this:
   
   - This bug is originated from  DefaultBulkScorer, we should not advance `filteredIterator.advance` if `collectorIterator` is already on `minDoc`
   - this bug affects not only `NumericComparator` but also `DocComparator`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org