[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #406: Throw an exception when using Iceberg with Spark embedded metastore

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #406: Throw an exception when using Iceberg with Spark embedded metastore
URL: https://github.com/apache/incubator-iceberg/pull/406#discussion_r317697046
 
 

 ##########
 File path: hive/src/main/java/org/apache/iceberg/hive/HiveClientPool.java
 ##########
 @@ -44,6 +48,14 @@ protected HiveMetaStoreClient newClient()  {
       return new HiveMetaStoreClient(hiveConf);
     } catch (MetaException e) {
       throw new RuntimeMetaException(e, "Failed to connect to Hive Metastore");
+    } catch (Throwable t) {
+      if (t.getMessage().contains("Another instance of Derby may have already booted")) {
+        LOG.error("Another instance of Derby may have already booted. This is happened when using" +
+            " embedded metastore, which only supports one client at time. Please change to use " +
+            "other metastores which could support multiple clients, like metastore service.", t);
 
 Review comment:
   It is fine to log this message, but I think the exception that is thrown should also contain it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org