You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/23 23:29:27 UTC
[GitHub] [beam] ibzib commented on a change in pull request #13915: [BEAM-11798] Support COVAR_POP function in Beam ZetaSQL
ibzib commented on a change in pull request #13915:
URL: https://github.com/apache/beam/pull/13915#discussion_r581465998
##########
File path: sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamSqlDslAggregationTest.java
##########
@@ -1010,4 +1012,39 @@ public void testCountIfFunction() throws Exception {
PAssert.that(result).containsInAnyOrder(rowResult);
pipeline.run().waitUntilFinish();
}
+
+ @Test
+ public void testCovarPopFunction() throws Exception {
Review comment:
We already have a test for covar_pop in https://github.com/apache/beam/blob/master/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamSqlDslAggregationCovarianceTest.java.
##########
File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SupportedZetaSqlBuiltinFunctions.java
##########
@@ -443,9 +443,9 @@
// FunctionSignatureId.FN_CORR, // corr
// FunctionSignatureId.FN_CORR_NUMERIC, // corr
// FunctionSignatureId.FN_CORR_BIGNUMERIC, // corr
- // FunctionSignatureId.FN_COVAR_POP, // covar_pop
- // FunctionSignatureId.FN_COVAR_POP_NUMERIC, // covar_pop
- // FunctionSignatureId.FN_COVAR_POP_BIGNUMERIC, // covar_pop
+ FunctionSignatureId.FN_COVAR_POP, // covar_pop
Review comment:
We shouldn't enable this if we know it doesn't work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org