You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/01/31 18:53:54 UTC
[GitHub] [maven] michael-o opened a new pull request #439: Avoid empty locations
michael-o opened a new pull request #439:
URL: https://github.com/apache/maven/pull/439
This one turns non-sense output like this:
```
[DEBUG] Looking up lifecycle mappings for packaging jar from ClassRealm[plexus.core, parent: null]
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[FATAL] input contained no data @
@
[ERROR] The build could not read 1 project -> [Help 1]
org.apache.maven.project.ProjectBuildingException: Some problems were encountered while processing the POMs:
[FATAL] input contained no data @
```
to this:
```
[DEBUG] Looking up lifecycle mappings for packaging jar from ClassRealm[plexus.core, parent: null]
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[FATAL] input contained no data
[ERROR] The build could not read 1 project -> [Help 1]
org.apache.maven.project.ProjectBuildingException: Some problems were encountered while processing the POMs:
[FATAL] input contained no data
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] MartinKanters commented on a change in pull request #439: Avoid empty locations
Posted by GitBox <gi...@apache.org>.
MartinKanters commented on a change in pull request #439:
URL: https://github.com/apache/maven/pull/439#discussion_r567469482
##########
File path: maven-core/src/main/java/org/apache/maven/exception/DefaultExceptionHandler.java
##########
@@ -149,7 +149,8 @@ private ExceptionSummary handle( ProjectBuildingResult result )
}
String message = System.lineSeparator()
- + "The project " + result.getProjectId() + " (" + result.getPomFile() + ") has "
+ + "The project " + ( result.getProjectId().isEmpty() ? "" : result.getProjectId() + " ")
Review comment:
Checkstyle fails on this line. The last ")" has to be prefixed with a space.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] asfgit merged pull request #439: Avoid empty locations
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #439:
URL: https://github.com/apache/maven/pull/439
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #439: Avoid empty locations
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #439:
URL: https://github.com/apache/maven/pull/439#discussion_r567471937
##########
File path: maven-core/src/main/java/org/apache/maven/exception/DefaultExceptionHandler.java
##########
@@ -149,7 +149,8 @@ private ExceptionSummary handle( ProjectBuildingResult result )
}
String message = System.lineSeparator()
- + "The project " + result.getProjectId() + " (" + result.getPomFile() + ") has "
+ + "The project " + ( result.getProjectId().isEmpty() ? "" : result.getProjectId() + " ")
Review comment:
Already fixed. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #439: Avoid empty locations
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #439:
URL: https://github.com/apache/maven/pull/439#issuecomment-770431091
This was found during https://issues.apache.org/jira/projects/MNG/issues/MNG-7087.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] MartinKanters commented on a change in pull request #439: Avoid empty locations
Posted by GitBox <gi...@apache.org>.
MartinKanters commented on a change in pull request #439:
URL: https://github.com/apache/maven/pull/439#discussion_r567469482
##########
File path: maven-core/src/main/java/org/apache/maven/exception/DefaultExceptionHandler.java
##########
@@ -149,7 +149,8 @@ private ExceptionSummary handle( ProjectBuildingResult result )
}
String message = System.lineSeparator()
- + "The project " + result.getProjectId() + " (" + result.getPomFile() + ") has "
+ + "The project " + ( result.getProjectId().isEmpty() ? "" : result.getProjectId() + " ")
Review comment:
Checkstyle fails on this line. The last ")" has to be prefixed with a space. (rest of MR looks good to me!)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org