You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "Matthias Weßendorf (JIRA)" <ji...@apache.org> on 2006/06/19 03:16:29 UTC

[jira] Created: (VALIDATOR-192) Adding ISBNValidator to GenericValidator

Adding ISBNValidator to GenericValidator
----------------------------------------

         Key: VALIDATOR-192
         URL: http://issues.apache.org/jira/browse/VALIDATOR-192
     Project: Commons Validator
        Type: Improvement

    Versions: 1.3.0 Release    
    Reporter: Matthias Weßendorf
    Priority: Minor


Inside the GenericValidator.java there is no method to check an isbn code.
Would be nice if such a "wrapper" method is implemented

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Updated: (VALIDATOR-192) Adding ISBNValidator to GenericValidator

Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/VALIDATOR-192?page=all ]

Niall Pemberton updated VALIDATOR-192:
--------------------------------------

    Fix Version/s: 1.4.0

> Adding ISBNValidator to GenericValidator
> ----------------------------------------
>
>                 Key: VALIDATOR-192
>                 URL: http://issues.apache.org/jira/browse/VALIDATOR-192
>             Project: Commons Validator
>          Issue Type: Improvement
>          Components: Routines
>    Affects Versions: 1.3.0 Release
>            Reporter: Matthias Weßendorf
>            Priority: Minor
>             Fix For: 1.4.0
>
>         Attachments: generic_validator.patch
>
>
> Inside the GenericValidator.java there is no method to check an isbn code.
> Would be nice if such a "wrapper" method is implemented

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Updated: (VALIDATOR-192) Adding ISBNValidator to GenericValidator

Posted by "Matthias Weßendorf (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/VALIDATOR-192?page=all ]

Matthias Weßendorf updated VALIDATOR-192:
-----------------------------------------

    Attachment: generic_validator.patch

here a goes a patch

> Adding ISBNValidator to GenericValidator
> ----------------------------------------
>
>          Key: VALIDATOR-192
>          URL: http://issues.apache.org/jira/browse/VALIDATOR-192
>      Project: Commons Validator
>         Type: Improvement

>     Versions: 1.3.0 Release
>     Reporter: Matthias Weßendorf
>     Priority: Minor
>  Attachments: generic_validator.patch
>
> Inside the GenericValidator.java there is no method to check an isbn code.
> Would be nice if such a "wrapper" method is implemented

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Updated: (VALIDATOR-192) Adding ISBNValidator to GenericValidator

Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/VALIDATOR-192?page=all ]

Niall Pemberton updated VALIDATOR-192:
--------------------------------------

    Component/s: Routines

> Adding ISBNValidator to GenericValidator
> ----------------------------------------
>
>                 Key: VALIDATOR-192
>                 URL: http://issues.apache.org/jira/browse/VALIDATOR-192
>             Project: Commons Validator
>          Issue Type: Improvement
>          Components: Routines
>    Affects Versions: 1.3.0 Release
>            Reporter: Matthias Weßendorf
>            Priority: Minor
>         Attachments: generic_validator.patch
>
>
> Inside the GenericValidator.java there is no method to check an isbn code.
> Would be nice if such a "wrapper" method is implemented

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (VALIDATOR-192) Adding ISBNValidator to GenericValidator

Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/VALIDATOR-192?page=comments#action_12418891 ] 

Niall Pemberton commented on VALIDATOR-192:
-------------------------------------------

Thanks for the patch but I would prefer if this wasn't done - in my mind there are two parts to Commons Validator - a framework and the validation routines and its one of my goals to see these clearly separated with the "routines" able to stand on their own with no dependency on the framework or anything else. As part of this process I started a new "routines" package (in Validator 1.3.0) with a new set of date/time/number routines:

http://jakarta.apache.org/commons/validator/apidocs/org/apache/commons/validator/routines/package-summary.html#package_description

The next step is to move the remaining routines (email, url, isbn, credit card, generic) into this package and deprecate the old ones. I've made a start on this, but I want to do some refactoring rather than just copy/move, but the upshot is new things IMO should go there rather than GenericValidator.


> Adding ISBNValidator to GenericValidator
> ----------------------------------------
>
>          Key: VALIDATOR-192
>          URL: http://issues.apache.org/jira/browse/VALIDATOR-192
>      Project: Commons Validator
>         Type: Improvement

>     Versions: 1.3.0 Release
>     Reporter: Matthias Weßendorf
>     Priority: Minor
>  Attachments: generic_validator.patch
>
> Inside the GenericValidator.java there is no method to check an isbn code.
> Would be nice if such a "wrapper" method is implemented

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org